Page MenuHomePhabricator

Newsletter notifications should be Notices instead of Alerts
Closed, ResolvedPublic

Description

The Notifications for "Foo has announced a new edition of Bar" should be grouped in the Notices section instead of the Alerts section.
Per https://www.mediawiki.org/wiki/Extension:Echo/Creating_a_new_notification_type#Defining_the_event_information ("Notices are for notifications that do not have to be dealt with promptly")

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Quiddity Is this all notifications or a specific kind?

@Quiddity Is this all notifications or a specific kind?

Oh, just for "New edition" notifications, I guess. Is there a list somewhere of all the notification types? I couldn't see anything in https://www.mediawiki.org/wiki/Help:Extension:Newsletter or https://www.mediawiki.org/wiki/Help:Notifications/Notifications_types

Is there a list somewhere of all the notification types?

sectionDefines the section this notification belongs to. There are two types, Alerts and Notices. Alerts are for urgent notifications that should be dealt with promptly, e.g. a post on the user's talk page. Notices are for notifications that do not have to be dealt with promptly, e.g. a thank. For Alerts, put 'alert'. For Notices, put 'message'

https://www.mediawiki.org/wiki/Extension:Echo/Creating_a_new_notification_type#Defining_the_event_information

Changing that in https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/83d94b8a705a2964082249301304ba3217664e57/Newsletter.hooks.php#L23 should do the trick

Change 391088 had a related patch set uploaded (by Chico Venancio; owner: Chico Venancio):
[mediawiki/extensions/Newsletter@master] [bugfix] Newsletter: notifications as Notices, not ALerts

https://gerrit.wikimedia.org/r/391088

Change 391088 had a related patch set uploaded (by Chico Venancio; owner: Chico Venancio):
[mediawiki/extensions/Newsletter@master] [bugfix] Newsletter: notifications as Notices, not ALerts

https://gerrit.wikimedia.org/r/391088

Can you paste a screenshot after this change ? Would be great.

Change 391088 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] [bugfix] Newsletter: notifications as Notices, not ALerts

https://gerrit.wikimedia.org/r/391088