Page MenuHomePhabricator

CodeSniffer to warn against usages of extract()
Closed, ResolvedPublic

Description

extract() sucks, we all know it. And we should try and prevent any future usages

Following on from T28496 and

<RoanKattouw> Does anyone know if we have any conventions or documentation officially deprecating/discouraging the use of extract() in PHP code?
<RoanKattouw> I'm writing a CR comment referring to someone's use of extract() saying it's evil and they shouldn't use it, but I can't find anything to back that up offhand

Event Timeline

Change 399142 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Forbid usage of extract()

https://gerrit.wikimedia.org/r/399142

Change 399142 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Forbid usage of extract()

https://gerrit.wikimedia.org/r/399142