Page MenuHomePhabricator
Create Task
Maniphest T180406

Interaction Timeline V1: Better date picker
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Problem to solve

The current date picker is sub-optimal in a few ways. Let's find a new one.

Acceptance criteria

  • A user should be allowed to type in the full date without having to refocus their cursor after every keystroke
  • The date picker should allow for selecting by year, such as on Special:Contributions
  • The picker should not allow a user to select an invalid date range (e.g. start date is 2017 while end date is 2016) by selecting.
  • The date should be displayed in YYYY-MM-DD format
  • Should be localizeable

Notes

The current date picker is pretty flexible, it's probably possible to do all of these things with it. However if you find a better date picker, feel free to swap it out.

Related Objects
Search...

Event Timeline

• TBolliger created this task.Nov 13 2017, 9:54 PM
• TBolliger moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Nov 13 2017, 10:49 PM
• TBolliger added a comment.Nov 17 2017, 7:37 PM

Also: look into a date picker that makes it easier to select by year.

• TBolliger set the point value for this task to 3.Nov 17 2017, 7:38 PM
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.
• TBolliger mentioned this in T179607: Interaction Timeline V1.Nov 27 2017, 9:10 PM
• TBolliger updated the task description. (Show Details)Nov 27 2017, 9:13 PM
• TBolliger mentioned this in T180083: Interaction Timeline V1: Error messages & fail states.Dec 6 2017, 5:20 PM
• TBolliger renamed this task from Interaction Timeline V1: Defect: Typing in the date fields only accepts one character before having to re-focus the field to Interaction Timeline V1: Better date picker.Dec 6 2017, 8:11 PM
• TBolliger updated the task description. (Show Details)Dec 11 2017, 9:58 PM
dbarratt updated the task description. (Show Details)Dec 12 2017, 7:54 PM
Huji edited projects, added: InteractionTimeline; removed: Anti-Harassment-Team.Dec 19 2017, 2:34 PM
• TBolliger added a project: Anti-Harassment-Team.Jan 4 2018, 5:36 PM
• TBolliger updated the task description. (Show Details)Jan 4 2018, 5:56 PM
• TBolliger removed the point value 3 for this task.
• TBolliger mentioned this in T184147: Interaction Timeline: Add a sane default value for the start date.
• TBolliger merged a task: T184147: Interaction Timeline: Add a sane default value for the start date.
• TBolliger moved this task from Cards ready for development to Triage/To be Estimated on the Anti-Harassment-Team board.
• TBolliger added subscribers: kaldari, • dmaza.

We'll need to re-size. The Acceptance criteria have changed a bit since initially estimated.

• TBolliger updated the task description. (Show Details)Jan 16 2018, 5:53 PM
• TBolliger updated the task description. (Show Details)Jan 16 2018, 7:52 PM
• TBolliger set the point value for this task to 3.
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.
• TBolliger moved this task from Cards ready for development to AHT Sprint 14 on the Anti-Harassment-Team board.Feb 1 2018, 8:03 PM
• TBolliger edited projects, added: Anti-Harassment-Team (AHT Sprint 14); removed: Anti-Harassment-Team.
dbarratt claimed this task.Feb 13 2018, 5:01 AM
dbarratt moved this task from Ready to In progress on the Anti-Harassment-Team (AHT Sprint 14) board.
dbarratt moved this task from In progress to Review on the Anti-Harassment-Team (AHT Sprint 14) board.Feb 13 2018, 10:27 PM
dbarratt added a comment.Feb 14 2018, 3:18 PM

@TBolliger What do you think?
https://tools.wmflabs.org/interaction-timeline/

• TBolliger added a comment.Feb 14 2018, 6:18 PM

Hey hey! looks and works pretty good for me on Mac/Chrome and Mac/Firefox!

The picker should not allow a user to select an invalid date range (e.g. start date is 2017 while end date is 2016) either via typing or selecting.

I'm going to kill the "via typing" requirement. The timeline doesn't bork if a user does this.

One final thing: can we get 'Start date' to one line on 1366 width? Currently it's wrapping to two.

• TBolliger updated the task description. (Show Details)Feb 14 2018, 6:19 PM
dbarratt added a comment.Feb 14 2018, 6:58 PM
In T180406#3972934, @TBolliger wrote:

The picker should not allow a user to select an invalid date range (e.g. start date is 2017 while end date is 2016) either via typing or selecting.

I'm going to kill the "via typing" requirement. The timeline doesn't bork if a user does this.

Yeah basically it doesn't update the query (see URL) unless the date is valid. You can type in an invalid date, but it wont do anything until it's valid.

One final thing: can we get 'Start date' to one line on 1366 width? Currently it's wrapping to two.

Done.
https://github.com/wikimedia/InteractionTimeline/pull/40

• TBolliger moved this task from AHT Sprint 14 to AHT Sprint 15 on the Anti-Harassment-Team board.Feb 14 2018, 7:40 PM
• TBolliger edited projects, added: Anti-Harassment-Team (AHT Sprint 15); removed: Anti-Harassment-Team (AHT Sprint 14).
• TBolliger moved this task from Ready to Review on the Anti-Harassment-Team (AHT Sprint 15) board.
dbarratt added a comment.Feb 16 2018, 6:19 PM

@TBolliger Please Review. :)
https://tools.wmflabs.org/interaction-timeline/

• TBolliger closed this task as Resolved.Feb 16 2018, 6:24 PM
• TBolliger moved this task from Review to Done on the Anti-Harassment-Team (AHT Sprint 15) board.

image.png (398×398 px, 74 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits