Maniphest T180412

Replace any debouncing with Vue.nextTick
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Milimetric
	Nov 13 2017, 10:56 PM

Tags

Referenced Files

None

Subscribers

Description

De-bouncing in Vue should be done with nextTick, as explained in the async update queue docs:

https://vuejs.org/v2/guide/reactivity.html#Async-Update-Queue

We have a few places where we just brute force this with setTimeouts that are prone to error.

Details

	Subject	Repo	Branch	Lines +/-
	Replace setTimeout with Vue.nextTick	analytics/wikistats2	master	+5 -4

Customize query in gerrit

Event Timeline

Milimetric created this task.Nov 13 2017, 10:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2017, 10:56 PM

Milimetric moved this task from In Progress to Next Up on the Analytics-Kanban board.Nov 15 2017, 3:53 AM

Milimetric reassigned this task from Milimetric to mforns.Jan 3 2018, 3:40 PM

mforns moved this task from Next Up to In Progress on the Analytics-Kanban board.Jan 3 2018, 5:06 PM

Change 402026 had a related patch set uploaded (by Mforns; owner: Mforns):
[analytics/wikistats2@master] Replace setTimeout with Vue.nextTick

https://gerrit.wikimedia.org/r/402026

gerritbot added a project: Patch-For-Review.Jan 4 2018, 12:02 PM

mforns moved this task from In Progress to In Code Review on the Analytics-Kanban board.Jan 4 2018, 12:03 PM

mforns set the point value for this task to 3.

Change 402026 merged by Milimetric:
[analytics/wikistats2@master] Replace setTimeout with Vue.nextTick

https://gerrit.wikimedia.org/r/402026

mforns moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Jan 4 2018, 5:06 PM

• fdans moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Jan 15 2018, 2:12 PM

• Nuria moved this task from Done to Ready to Deploy on the Analytics-Kanban board.Jan 16 2018, 4:05 PM

• fdans moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Jan 19 2018, 11:37 AM

• Nuria closed this task as Resolved.Feb 12 2018, 3:53 PM