Page MenuHomePhabricator
Create Task
Maniphest T180413

Use supplied link text rather than display title when link text matches page title except for case of first character
Closed, ResolvedPublic
Actions

Description

Setup

  • MediaWiki 1.29.1 (ef41aab) 00:01, 3 November 2017
  • PHP 5.6.30-0+deb8u1 (apache2handler)
  • DisplayTitle 1.5.1 (9ca95b6) 03:23, 3 November 2017

Issue
I think this extension should honor the alternative link label if provided, e.g. show "displayTitle" in case it was explicitly defined with [[DisplayTitle|displayTitle]] instead of "Changed display title example" which was added to the "DisplayTitle" page with {{DISLPLAYTITLE:Changed display title example}}.

Live example:

Side note: What wonders me is that [[DisplayTitle|displaytitle]] renders as "displaytitle" whereas [[DisplayTitle|displayTitle]] renders as "Changed display title example". Hmm ...

Details

SubjectRepoBranchLines +/-
Fix override of link text.mediawiki/extensions/DisplayTitlemaster+20 -8
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Nov 13 2017, 11:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2017, 11:06 PM
Kghbln added a comment.Nov 14 2017, 9:26 AM

In my initial report I mostly focused on describing a solution than actually elaborating on the issue I would like to solve.

The issue basically is that if I set a display title on a page the first letter will in most cased be an upper case character. However when I am linking to that very page from another page within a text this upper case character is being preserved thought since I am in the middle of some text I would like in most cases the first letter to be a lower case character.

To cut it short I would like to have "On this page I am adding a link to the changed display title example" instead of the current "On this page I am adding a link to the Changed display title example".

I figure that explicitly setting an alternative label may be a solution if honored.

Kghbln updated the task description. (Show Details)Nov 14 2017, 9:26 AM
gerritbot subscribed.Nov 23 2017, 3:56 AM

Change 393000 had a related patch set uploaded (by Cicalese; owner: Cindy Cicalese):
[mediawiki/extensions/DisplayTitle@master] Fix override of link text.

https://gerrit.wikimedia.org/r/393000

gerritbot added a project: Patch-For-Review.Nov 23 2017, 3:56 AM
cicalese mentioned this in rEDPTbcc639fb3dd3: Fix override of link text..Nov 23 2017, 5:33 AM
cicalese mentioned this in rEDPTf1cfeb428119: Fix override of link text..
cicalese mentioned this in rEDPTf0c8d119391c: Fix override of link text..Nov 24 2017, 12:55 PM
gerritbot added a comment.Nov 24 2017, 5:02 PM

Change 393000 merged by Cicalese:
[mediawiki/extensions/DisplayTitle@master] Fix override of link text.

https://gerrit.wikimedia.org/r/393000

CCicalese_WMF renamed this task from To honor alternative link label to Use supplied link text rather than display title when link text matches page title except for case of first character.Nov 24 2017, 5:14 PM
cicalese closed this task as Resolved.Jan 11 2018, 3:10 PM
cicalese claimed this task.
cicalese removed a project: Patch-For-Review.
cicalese moved this task from Backlog to Closed on the MediaWiki-extensions-DisplayTitle board.Jan 11 2018, 3:15 PM
Kghbln mentioned this in rEDPT0ab0fb6841bd: Update patch set 5.Jun 9 2018, 11:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits