Page MenuHomePhabricator

Do not display banners when users are using the "simple" search field
Closed, ResolvedPublic

Description

The search suggestions of the simple search feature collides with our banners. To make sure the page elements are still being displayed properly, we need to change the banner behaviour and tweak its layout:

  • The z-index of the banner container is set to a number that prevents the search suggestion container to overlap the banner.
  • When the simple search field is focused, the banner does not display.
  • When the banner is not being displayed for these cases, a tracking event is sent

Event Timeline

kai.nissen moved this task from Backlog to Ready on the WMDE-Fundraising-Funban-2 board.

A pull request that demonstrates how the code will look is at https://github.com/wmde/fundraising-banners/pull/52

If the PR is accepted, the other banners (desktop and mobile VAR, ipad and english) need to be modified accordingly.