Don't duplicate fieldset elements in OOUI HTMLForm output
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Nov 14 2017, 10:42 PM

Description

fieldset elements and their optional legend elements are structural markup.
In case of the new Special:Preferences page we're outputting

<fieldset id="mw-prefsection-personal-info" class="oo-ui-layout oo-ui-labelElement oo-ui-fieldsetLayout">
	<legend class="oo-ui-fieldsetLayout-header">
		<span class="oo-ui-iconElement-icon"></span>
		<span class="oo-ui-labelElement-label">Basisinformationen</span>
	</legend>
	<div class="oo-ui-fieldsetLayout-group">
		<div aria-disabled="false" class="oo-ui-widget oo-ui-widget-enabled">
			<fieldset id="mw-htmlform-info" class="oo-ui-layout oo-ui-fieldsetLayout">
				<legend class="oo-ui-fieldsetLayout-header">
					<span class="oo-ui-iconElement-icon"></span>
					<span class="oo-ui-labelElement-label"></span>
				</legend>
				<div class="oo-ui-fieldsetLayout-group">
				[…]
				</div>
			</fieldset>
		</div>
	</div>
</fieldset>

which, especially with the empty legend element in the child fieldset is unnecessary, leads to layout issues and might even result in making screenreaders trip.

Details

Subject	Repo	Branch	Lines +/-
FieldsetLayout: Hide header when there is no icon or label	oojs/ui	master	+7 -5
OOUIHTMLForm: Prevent duplicate FieldsetLayout wrapping	mediawiki/core	master	+39 -31
Hide empty OOUI FieldsetLayout headers	mediawiki/core	master	+8 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open	None	T100161 Convert all of MediaWiki core to OOUI PHP (tracking)
Open	None	T101480 Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path
Open	None	T101471 Convert core forms that use MW UI with wgUseMediaWikiUIEverywhere false to OOUI FormSpecialPage or explicit OOUI PHP
Open	None	T107037 Convert all MW core special pages to OOUI
Open	None	T64559 Redesign Special:Preferences (tracking)
Resolved	Volker_E	T180538 Improve Special:Preferences UI/UX
Resolved	Volker_E	T117781 Convert Special:Preferences to OOUI
Resolved	matmarex	T180535 Don't duplicate fieldset elements in OOUI HTMLForm output

Event Timeline

Volker_E created this task.Nov 14 2017, 10:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2017, 10:42 PM

Change 391354 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Hide empty OOUI FieldsetLayout headers

https://gerrit.wikimedia.org/r/391354

gerritbot added a project: Patch-For-Review.Nov 14 2017, 11:05 PM

Volker_E mentioned this in T180538: Improve Special:Preferences UI/UX.Nov 15 2017, 12:24 AM

Mainframe98 subscribed.Nov 15 2017, 5:17 AM

Jdforrester-WMF added a parent task: T180538: Improve Special:Preferences UI/UX.Nov 15 2017, 10:32 PM

It would be much easier for us to set display: none; on the <legend> when there is no label/icon, than to completely remove the element from the DOM. We would have to override setLabel/setIcon to also check whether both label/icon are missing and accordingly remove/insert the element. It can be done, but unless we are sure it's requires, I think it would be an unnecessary complication. As far as I know nothing in HTML prohibits <legend> from being (effectively) empty.

Change 391764 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] FieldsetLayout: Hide header when there is no icon or label

https://gerrit.wikimedia.org/r/391764

Okay, the task description actually had me confused, since it talks a lot about the legends… the real problem here is not the empty legend (although it's good to fix that); it's the fact that the entire thing is wrapped in two layers of FieldsetLayout. That is not an OOUI bug, MediaWiki code is doing it wrong here.

Change 391354 merged by jenkins-bot:
[mediawiki/core@master] Hide empty OOUI FieldsetLayout headers

https://gerrit.wikimedia.org/r/391354

Change 391781 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] OOUIHTMLForm: Prevent duplicate FieldsetLayout wrapping

https://gerrit.wikimedia.org/r/391781

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 16 2017, 11:00 AM

Change 391781 merged by jenkins-bot:
[mediawiki/core@master] OOUIHTMLForm: Prevent duplicate FieldsetLayout wrapping

https://gerrit.wikimedia.org/r/391781

matmarex closed this task as Resolved.Nov 16 2017, 6:15 PM

matmarex claimed this task.

matmarex removed a project: Patch-For-Review.

Change 391764 merged by jenkins-bot:
[oojs/ui@master] FieldsetLayout: Hide header when there is no icon or label

https://gerrit.wikimedia.org/r/391764

Izno edited parent tasks, added: T117781: Convert Special:Preferences to OOUI; removed: T180538: Improve Special:Preferences UI/UX.Sep 18 2018, 10:39 PM

Don't duplicate fieldset elements in OOUI HTMLForm outputClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Don't duplicate fieldset elements in OOUI HTMLForm output
Closed, ResolvedPublic
Actions

Related Objects
Search...