Hi, this is a git-review tool that is owned and maintained by openstack. See https://github.com/openstack-infra/git-review

You may want to contribute the patch there as this tool is not maintained or has been created by gerrit upstream :).

https://github.com/openstack-infra/git-review/blob/b61f5b2ec9ab140960a1c6e0a424389cdd8951a0/git_review/cmd.py#L1231

https://github.com/openstack-infra/git-review/search?utf8=✓&q=set+upstream&type=

I just noticed there already is a patch for this at https://review.openstack.org/#/c/517831/

Merging that patch will be the first step to resolve this. However, it seems nobody does releases of git-review nowadays. We will need to either beat them until somebody does a release or document that git-review needs to be built from source now (and how to do that). The latter of which shouldn't become more that a short-term solution, as it may raise the barrier for new contributors even more.

it seems nobody does releases of git-review nowadays

How about asking the maintainer of the Debian package? Which is.. the openstack-devel list.

Maintainer: PKG OpenStack <openstack-devel@lists.alioth.debian.org>

If I can plug one of my own tools: https://github.com/legoktm/grr. It's pretty simple to use, but has a different model of development as it relies on detached HEADs and not branches.

Whilst at it should we fix that issue with having a base url for https clones? Base url as in /r as many users are having issues with it trying /changes/ instead of /r/changes/?

I wonder where that comes from since i have used git review for many many years and don't remember ever having that issue you are referring too, Paladox.

@Dzahn there’s a task around some where but there have been many tasks. Even been asked privately about it.

I can look for the task later but may be harder to find if it was declined?

In T180548#3761947, @Legoktm wrote:

If I can plug one of my own tools: https://github.com/legoktm/grr. It's pretty simple to use, but has a different model of development as it relies on detached HEADs and not branches.

I've got this super awesome tool, you might already have it installed. It's pretty easy to use and doesn't rely on an absentee upstream like git-review. It's called git.

In T180548#3761447, @EddieGP wrote:

I just noticed there already is a patch for this at https://review.openstack.org/#/c/517831/
Merging that patch will be the first step to resolve this.

This has happened meanwhile. "Support git 2.15 and newer" has been merged upstream. :)

Upstream are planning on releasing a new version soon :).

They may also include a fix for this T154760

Thanks. Please do try it and report back that it’s fixed :)

In T180548#3781186, @Paladox wrote:

Thanks. Please do try it and report back that it’s fixed :)

It is, that's why I closed the task ;-)

eddie@eddie-thinkpad:~/develop/mediawiki/extensions/ThrottleOverride (master)$ git review --version
git-review version 1.26.0
eddie@eddie-thinkpad:~/develop/mediawiki/extensions/ThrottleOverride (master)$ git review -d 392556
Downloading refs/changes/56/392556/4 from gerrit
Switched to branch "review/bryandavis/392556"