Page MenuHomePhabricator

HTML comments inside galleries cause images not to be rendered
Open, LowPublic


Author: bugs

This doesn't work:

Image:foo.jpg <-- image taken from -->

Seems useful and should work.

Version: 1.20.x
Severity: minor

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:16 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz16057.
bzimport added a subscriber: Unknown Object (MLST).


Image:foo.jpg| <!-- image taken from -->

Notice the vertical bar/pipe (|) and the exclamation mark (!).

bugs wrote:

Interesting - that's sort of a workaround, in that you're specifying a blank caption. It still seems like some kind of bug/limitation (is there anywhere else that <!-- comments --> aren't allowed?) but not severe.

Change 532249 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] parser: Strip off HTML comments from/beside image name

Change 532249 abandoned by D3r1ck01:
parser: Strip off HTML comments from/beside image name

Per discussion with Krinkle