Page MenuHomePhabricator

HTML comments inside galleries cause images not to be rendered
Open, LowPublic

Description

Author: bugs

Description:
This doesn't work:

<gallery>
Image:foo.jpg <-- image taken from www.source.com -->
</gallery>

Seems useful and should work.


Version: 1.20.x
Severity: minor

Details

Reference
bz16057

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:16 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz16057.
bzimport added a subscriber: Unknown Object (MLST).

Try:

<gallery>
Image:foo.jpg| <!-- image taken from www.source.com -->
</gallery>

Notice the vertical bar/pipe (|) and the exclamation mark (!).

bugs wrote:

Interesting - that's sort of a workaround, in that you're specifying a blank caption. It still seems like some kind of bug/limitation (is there anywhere else that <!-- comments --> aren't allowed?) but not severe.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2015, 11:12 PM
Ramsey-WMF moved this task from Untriaged to Backlog on the Multimedia board.Nov 28 2017, 8:49 PM

Change 532249 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] parser: Strip off HTML comments from/beside image name

https://gerrit.wikimedia.org/r/532249

Krinkle edited projects, added Parsing-Team; removed Multimedia.Aug 25 2019, 4:57 PM
Krinkle removed a subscriber: wikibugs-l-list.

Change 532249 abandoned by D3r1ck01:
parser: Strip off HTML comments from/beside image name

Reason:
Per discussion with Krinkle

https://gerrit.wikimedia.org/r/532249