Page MenuHomePhabricator

NavigationTimingv2 misses mediaWikiLoadComplete
Closed, ResolvedPublic

Description

It is a miss match in navtiming2 what is sent from the user (mediaWikiLoadComplete) but the code expect mediaWikiLoadEnd and mediaWikiLoadStart (and then calculate the newly named mediaWikiLoad). Let me fix that so we can soon start use the schema.

Details

Related Gerrit Patches:

Event Timeline

Peter created this task.Nov 15 2017, 1:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2017, 1:12 PM

Change 392036 had a related patch set uploaded (by Phedenskog; owner: Phedenskog):
[operations/puppet@production] webperf: Add missing mediaWikiLoad to navtiming2

https://gerrit.wikimedia.org/r/392036

Peter added a subscriber: Krinkle.Nov 17 2017, 12:12 PM

I've changed the name to mediaWikiLoad (the delta, I think we said that when we started) and then just skipped start/end, or do you see a need for them @Krinkle ?

Krinkle added a comment.EditedNov 17 2017, 8:12 PM

I've changed the name to mediaWikiLoad (the delta, I think we said that when we started) and then just skipped start/end, or do you see a need for them @Krinkle ?

Using mediaWikiLoad looks good, yeah.

As for needing the others, yes and no :) Yes, we do want one of them (mediaWikiLoadEnd), because per T160315 this event would be more useful as an offset instead of a delta. But the current client code only sends mediaWikiLoadComplete (a delta). It does have mediaWikiLoadStart/End, but those are not sent, so.. no we don't need those in webperf.py right now.

Gilles moved this task from Inbox to Doing on the Performance-Team board.Nov 20 2017, 9:19 PM

Change 392036 merged by Dzahn:
[operations/puppet@production] webperf: Add missing mediaWikiLoad to navtiming2

https://gerrit.wikimedia.org/r/392036