Maniphest T180632

[BUG] Explore "Save for later" button touch target is too small
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Nov 15 2017, 8:27 PM

Tags

Referenced Files

None

Subscribers

Description

How many times were you able to reproduce it?

All

Steps to reproduce

Tap an Explore "Save for later" button, but aim a tiny bit above or below the "Save for later" text

Expected results

Toggles save state

Actual results

Navigates to the article

Screenshots

Environments observed

App version:
5.8

OS versions:
iOS 11

Device model:
iPhone 6s Plus and X

Device language:
EN (all?)

Related Objects

Mentioned In: rAPIOSeba102a20cc3: Merge pull request #1959 from onlyrandomness/bug/T180632
rAPIOS6ecf893963f9: Merge remote-tracking branch 'upstream/develop' into bug/T180632
rAPIOSd10c6270d868: Merge branch 'bug/T180632' of https://github.com/onlyrandomness/wikipedia-ios…
rAPIOSd61976d73946: Merge branch 'develop' into bug/T180632

Event Timeline

Mhurd created this task.Nov 15 2017, 8:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2017, 8:27 PM

• JMinor triaged this task as Low priority.Nov 27 2017, 8:21 PM

• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.

Onlyrandomness claimed this task.Nov 29 2017, 10:54 AM

Onlyrandomness added a project: iOS-app-v5.7.4-Dachshund-On-An-Elk.Nov 30 2017, 2:31 AM

Onlyrandomness moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.

Onlyrandomness moved this task from Doing to Needs Code Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 30 2017, 3:46 AM

JoeWalsh mentioned this in rAPIOSd61976d73946: Merge branch 'develop' into bug/T180632.Nov 30 2017, 11:15 AM

Onlyrandomness mentioned this in rAPIOSd10c6270d868: Merge branch 'bug/T180632' of https://github.com/onlyrandomness/wikipedia-ios….Dec 1 2017, 12:37 AM

Onlyrandomness mentioned this in rAPIOS6ecf893963f9: Merge remote-tracking branch 'upstream/develop' into bug/T180632.Dec 1 2017, 12:44 AM

JoeWalsh mentioned this in rAPIOSeba102a20cc3: Merge pull request #1959 from onlyrandomness/bug/T180632.Dec 1 2017, 6:39 PM

Onlyrandomness moved this task from Needs Code Review to Needs Design Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 8 2017, 6:30 AM

Works well for me! Thanks @Onlyrandomness !

Testing on iPhone 6 Plus (iOS 11.1.2) and iPhone 6s (iOS 10.3.3) - Wikipedia app 5.7.3 (1281). It still navigates to the article if I tap above or to the right of the "save for later" button, only tapping on the button or link saves it. So this is not fixed as expected.

Wikipedia app 5.7.3 (1281) - Feels larger, but as @Nicholas.tsg mentioned, it feels like it could be a bit taller. I think it's pretty good tho...

• JMinor closed this task as Resolved.Jan 8 2018, 10:43 PM