Page MenuHomePhabricator

Interaction Timeline V1: Support IP users
Closed, ResolvedPublic3 Estimated Story Points


Problem to solve

The Timeline does not allow users to compare the edits of IP users

Acceptance criteria

  • Users should be able to paste or type in exact IPv4 (example) and IPv6 (example) addresses into the username select, if edits have ever been made from those accounts.
  • Don't worry about autoselecting/autosuggesting IPs
  • The timeline should function and treat the IP address exactly as it treats usernames


  • IP ranges and CIDR searches will be handled later, once T177150 is complete
  • Perhaps use Creatable and validate onChange or in the reducer? I think this is the direction I would try first.

Event Timeline

@dmaza — I think there are two bugs when using IPv6 addresses. They may be two symptoms of the same problem. I have not seen them happen independently.

I haven't been able to recreate these issues with IPv4 addresses or usernames, but my testing was limited.) These were tested on latest Chrome/Mac

Bug 1 - Edit card background color does not display — This IP does not display the blue box around the IP's edit:

Screen Shot 2018-01-02 at 1.14.55 PM.png (510×1 px, 91 KB)

Bug 2 - IPv6 edits always show in right column — IPv6 edits always show on the right (as in left/right, not as in 'correct') column: and and and

If you swap the first/second order of the IP and the other user you will see.

Screen Shot 2018-01-02 at 1.22.30 PM.png (247×1 px, 41 KB)

Note These problems are not happening here:

This is very strange. Looking into it