Page MenuHomePhabricator

Email preferences should show as disabled/enabled, not hide/show
Closed, InvalidPublic

Description

Current behavior

The list only shows if the "Allow emails" tickbox is ticked and requires the user to save the page:


Requested new behavior

  • The Email blacklist should always display
  • The "allow emails from new users" tickbox should always display
  • If "Allow emails" is ticked, these 2 preferences should be active and functional
  • If "Allow emails" is unticked, these 2 preferences should be inactive and the contents should be uneditable.
  • Whatever is in the textbox and tickbox (regardless of 'allow emails' status) when 'Save' is clicked should be saved.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2017, 7:10 PM
TBolliger removed the point value for this task.
dmaza renamed this task from Email Mute/prohibit/blacklist: In the preferences UI, the list should shows as disabled/enabled, not hide/show to Email Mute/prohibit/blacklist: In the preferences UI, the list should show as disabled/enabled, not hide/show.Nov 16 2017, 7:13 PM

Ideally... this would use OOUI to hide and show the fields immediately. That way it keeps the UI clean and it is clear what is being added/removed as a result of your choices.

TBolliger updated the task description. (Show Details)
TBolliger set the point value for this task to 2.Nov 17 2017, 7:05 PM
TBolliger changed the task status from Open to Stalled.Dec 7 2017, 7:10 PM
TBolliger removed the point value for this task.
TBolliger renamed this task from Email Mute/prohibit/blacklist: In the preferences UI, the list should show as disabled/enabled, not hide/show to Email preferences should show as disabled/enabled, not hide/show (blocked by OOUI).Dec 7 2017, 7:12 PM
TBolliger updated the task description. (Show Details)
dmaza added a subscriber: dmaza.Dec 8 2017, 12:18 AM

As part of T138165 (patch here) the email blacklist will never be hidden unless it is disabled by config. It will be shown disabled if an email has not been setup. If there is an email address, it will remain visible and enabled regardless of Allow other users to email me. Is this acceptable or do I need to change it?

As part of T138165 (patch here) the email blacklist will never be hidden unless it is disabled by config. It will be shown disabled if an email has not been setup. If there is an email address, it will remain visible and enabled regardless of Allow other users to email me. Is this acceptable or do I need to change it?

Acceptable. Ship it.

(Blacklisted users won't be able to send emails because nobody will be able to send emails, so it's not entirely lying. Just very suboptimal.)

TBolliger renamed this task from Email preferences should show as disabled/enabled, not hide/show (blocked by OOUI) to Email preferences should show as disabled/enabled, not hide/show .Oct 3 2018, 5:05 PM
TBolliger changed the task status from Stalled to Open.
TBolliger moved this task from Analytics to Product backlog on the Anti-Harassment board.
TBolliger closed this task as Invalid.Jan 30 2019, 10:20 PM