Add ConstraintCheckPlan class
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Lucas_Werkmeister_WMDE
	Nov 17 2017, 3:42 PM

Description

The ConstraintCheckPlan class holds a list of constraint checks to perform and can optionally optimize this list before performing the checks. This enables several optimizations that should help T103228: Improve performance of constraint check.

Details

	Subject	Repo	Branch	Lines +/-
	Add tests for ConstraintCheckPlan	mediawiki/extensions/WikibaseQualityConstraints	master	+314 -0
	Introduce ConstraintCheckPlan class	mediawiki/extensions/WikibaseQualityConstraints	master	+262 -231

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Open	None	T103228 Improve performance of constraint check
Open	None	T163683 Only check per-item constraints once, instead of with each statement
Open	None	T180798 Only check reference constraints once
Open	None	T180799 Only parse constraint exceptions once per constraint
Declined	None	T180796 Add ConstraintCheckPlan class

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 17 2017, 3:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2017, 3:42 PM

Lucas_Werkmeister_WMDE added a parent task: T180798: Only check reference constraints once.Nov 17 2017, 3:45 PM

Lucas_Werkmeister_WMDE added a parent task: T180799: Only parse constraint exceptions once per constraint.Nov 17 2017, 3:53 PM

Change 374592 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Introduce ConstraintCheckPlan class

https://gerrit.wikimedia.org/r/374592

Change 392054 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for ConstraintCheckPlan

https://gerrit.wikimedia.org/r/392054

Lucas_Werkmeister_WMDE mentioned this in T181080: Add cacheable layer between CheckConstraints and DelegatingConstraintChecker.Nov 21 2017, 7:08 PM

Lydia_Pintscher moved this task from incoming to other on the Wikibase-Quality-Constraints board.Apr 6 2018, 3:07 PM

Change 374592 abandoned by Lucas Werkmeister (WMDE):
Introduce ConstraintCheckPlan class

https://gerrit.wikimedia.org/r/374592

Change 392054 abandoned by Lucas Werkmeister (WMDE):
Add tests for ConstraintCheckPlan

https://gerrit.wikimedia.org/r/392054

Lucas_Werkmeister_WMDE closed this task as Declined.Nov 25 2019, 7:01 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 11:59 AM