Only parse constraint exceptions once per constraint
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Lucas_Werkmeister_WMDE
	Nov 17 2017, 3:53 PM

Description

We currently re-parse the constraint parameters for the exceptions every time we check a constraint, even though they don’t change with the context. That’s unnecessary.

Details

	Subject	Repo	Branch	Lines +/-
	Cache constraint exceptions	mediawiki/extensions/WikibaseQualityConstraints	master	+33 -9

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Open	None	T103228 Improve performance of constraint check
Open	None	T180799 Only parse constraint exceptions once per constraint
Declined	None	T180796 Add ConstraintCheckPlan class

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 17 2017, 3:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2017, 3:53 PM

Lucas_Werkmeister_WMDE added a subtask: T180796: Add ConstraintCheckPlan class.Nov 17 2017, 3:53 PM

Lucas_Werkmeister_WMDE mentioned this in T180801: Only parse constraint parameters once per constraint.Nov 17 2017, 4:02 PM

Change 392061 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Cache constraint exceptions

https://gerrit.wikimedia.org/r/392061

gerritbot added a project: Patch-For-Review.Nov 17 2017, 4:02 PM

Lydia_Pintscher moved this task from incoming to other on the Wikibase-Quality-Constraints board.Apr 6 2018, 3:07 PM

Change 392061 abandoned by Lucas Werkmeister (WMDE):
Cache constraint exceptions

https://gerrit.wikimedia.org/r/392061

Lucas_Werkmeister_WMDE closed subtask T180796: Add ConstraintCheckPlan class as Declined.Nov 25 2019, 7:01 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 11:58 AM