When VisualDiff times out, please tell the user
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Whatamidoing-WMF
	Nov 17 2017, 8:18 PM

Description

Because of timeouts, different users/computers/situations may see different things with the same diff. This could be awkward under some circumstances, e.g., in a workshop setting. If it times out, please tell the user.

Originally reported by the faithful 197.218 at https://www.mediawiki.org/wiki/Topic:U1ug6fhxbqgs59vl

Details

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (dc5a65131)	mediawiki/extensions/VisualEditor	wmf/1.31.0-wmf.25	+3 -2
Update VE core submodule to master (dc5a65131)	mediawiki/extensions/VisualEditor	master	+3 -2
Show timeout message if diff times out	VisualEditor/VisualEditor	master	+53 -4

Customize query in gerrit

Related Objects

Mentioned In: T188170: Visual diff doesn't highlight changes inside a container
Mentioned Here: rGVEDdc5a65131a8f: Merge "ve.Node: Make #getOffsetPath not fail while rebuilding the document"

Event Timeline

• Whatamidoing-WMF created this task.Nov 17 2017, 8:18 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptNov 17 2017, 8:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Whatamidoing-WMF updated the task description. (Show Details)Nov 17 2017, 8:19 PM

• Deskana triaged this task as Medium priority.Nov 20 2017, 1:49 PM

• Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

• Deskana set the point value for this task to 1.

Tchanders moved this task from TR6: Visual diffs to Current work on the VisualEditor board.Feb 17 2018, 1:20 PM

Tchanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Tchanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Tchanders claimed this task.Feb 17 2018, 1:23 PM

Tchanders mentioned this in T188170: Visual diff doesn't highlight changes inside a container.Mar 3 2018, 4:19 PM

Change 416230 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Show timeout message if diff times out

https://gerrit.wikimedia.org/r/416230

gerritbot added a project: Patch-For-Review.Mar 3 2018, 4:59 PM

Tchanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Mar 3 2018, 5:05 PM

Change 416230 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Show timeout message if diff times out

https://gerrit.wikimedia.org/r/416230

TheDJ awarded a token.Mar 14 2018, 3:25 PM

Change 419512 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (dc5a65131)

https://gerrit.wikimedia.org/r/419512

Change 419512 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (dc5a65131)

https://gerrit.wikimedia.org/r/419512

Change 419518 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.25] Update VE core submodule to master (dc5a65131)

https://gerrit.wikimedia.org/r/419518

This patch got caught in a backport (see https://gerrit.wikimedia.org/r/419518 and the bugs there, for boring technical reasons it's easier to include it). This should be harmless.

Also, it's fixed, and I verified it works with MW.

Change 419518 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.25] Update VE core submodule to master (dc5a65131)