Page MenuHomePhabricator

Update/cleanup submodule of extensions Widget
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/c/383755/

Chad wrote:

Remove Widgets extension as submodule from meta repo

The extension is currently broken in git, and updating this repo
leaves one with a dirty clone that cannot be cleaned up. The error
is as follows:

error: Server does not allow request for unadvertised object 35480f10e7ce9b0fdaf23d3799d7b79463919b1e
Fetched in submodule path 'smarty', but it did not contain 35480f10e7ce9b0fdaf23d3799d7b79463919b1e. Direct fetching of that commit failed.

It has to do with the submodule in question that it makes use of.
If someone can fix the repo, this change can be reverted.

Umherirrender wrote:

It is an old commit - https://github.com/smarty-php/smarty/commit/35480f10e7ce9b0fdaf23d3799d7b79463919b1e

The commit has a tag.

last commit is https://github.com/smarty-php/smarty/commit/3d7dece0886a64ef4a2b78e16b7b3be5a1edc37d

When check out the tag directly the clone looks clean. I would say the submodule version is hard coded, but cloning the submodule does not use this information. See https://phabricator.wikimedia.org/rEWIDcc587f193a377fa6532a2ca26994b269d38dbacb

There is no need to ignore the extensions due to problem with the submodule.

Please update the submodule or clean up the config to avoid check out of the last master

Event Timeline

Smarty is brought in by Composer now, so it should work out now.

Change 467894 had a related patch set uploaded (by MGChecker; owner: MGChecker):
[mediawiki/extensions@master] Revert "Remove Widgets extension as submodule from meta repo"

https://gerrit.wikimedia.org/r/467894

Change 467894 abandoned by Umherirrender:
Revert "Remove Widgets extension as submodule from meta repo"

Reason:
Was already readded with If14466

https://gerrit.wikimedia.org/r/467894

Umherirrender triaged this task as Medium priority.