Page MenuHomePhabricator

SecureHTML::secureHTMLRender() should not be called statically
Closed, ResolvedPublic


I have error reporting on in LocalSettings.php:

error_reporting( -1 );
ini_set( 'display_errors', 1 );

Now every time one of my pages uses a secure html block (from I get the message:

Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method SecureHTML::secureHTMLRender() should not be called statically in /mediawiki/includes/parser/Parser.php on line 4279

If I have 3 secure html elements on one page, I get that message 3 times.

This issue was also reported before at

Event Timeline

TTO added a subscriber: TTO.

Apparently Ryan Finnie, the author of this extension, doesn't have a Phabricator account.

Change 392193 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecureHTML@master] Make static functions static

Thanks for your quick reply.
Tried the patch on my install and it works fine.

I'm not familiar with the review process though (yet).

Change 392193 merged by jenkins-bot:
[mediawiki/extensions/SecureHTML@master] Make static functions static

Umherirrender assigned this task to Reedy.
Umherirrender triaged this task as Medium priority.