Page MenuHomePhabricator
Create Task
Maniphest T180987

Inconsistent descriptions in the Newsletter interface for creating and unsubscribing
Closed, ResolvedPublic
Actions

Description

Summary
The description of what users are looking at is inconsistent in our language describing the interface.

Description
On the page for creating a newsletter the opening starts with "This page allows you to create a new newsletter". On the page for unsubscribing it states, "This interface allows you to unsubscribe from "Tech Showcase" newsletter." Emphasis added.

We should pick one way of describing what users are looking at. Is it a "page" or is it an "interface". I suggest the former, "page", as it's more common of a word and sounds less technical than "interface".

Details

SubjectRepoBranchLines +/-
Fix inconsistent descriptions in interface for creating and unsubscribingmediawiki/extensions/Newslettermaster+2 -2
Customize query in gerrit

Event Timeline

Ckoerner created this task.Nov 20 2017, 7:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2017, 7:17 PM
QuimGil added a project: Google-Code-in-2017.Nov 21 2017, 9:42 AM
QuimGil subscribed.

Thank you, good catch! Yes, "page" is better.

This is a good candidate for Google-Code-in-2017. Double thanks!

Aklapper moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2017 board.Nov 21 2017, 11:19 AM

Who would/could mentor this for Google-Code-in-2017 ?

MtDu subscribed.Nov 21 2017, 3:55 PM

I can help mentor this @Aklapper

Aklapper moved this task from Missing mentors to Imported in GCI Site on the Google-Code-in-2017 board.Nov 27 2017, 8:13 PM

Thanks! Published as https://codein.withgoogle.com/tasks/4777835023564800/

divadsn claimed this task.EditedDec 1 2017, 7:53 AM
divadsn subscribed.

I will work on this task, I think the former "page" is more accurate for the average user to understand, as @Ckoerner already said :)

gerritbot subscribed.Dec 1 2017, 7:00 PM

Change 394635 had a related patch set uploaded (by Divadsn; owner: Divadsn):
[mediawiki/extensions/Newsletter@master] Fix inconsistent descriptions in interface for creating and unsubscribing

https://gerrit.wikimedia.org/r/394635

gerritbot added a project: Patch-For-Review.Dec 1 2017, 7:00 PM
MtDu added a comment.Dec 1 2017, 7:34 PM

task approved @divadsn

Thanks!

divadsn closed this task as Resolved.Dec 1 2017, 8:36 PM
01tonythomas subscribed.Dec 1 2017, 8:39 PM

@divadsn Great work. just to let you know that a task is closed as Resolved only after the corresponding patchests that fix it gets merged to master branch (or wherever it should go to). Not a problem, but just keep in mind from next time.

gerritbot added a comment.Dec 1 2017, 8:39 PM

Change 394635 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Fix inconsistent descriptions in interface for creating and unsubscribing

https://gerrit.wikimedia.org/r/394635

divadsn added a comment.Dec 1 2017, 8:43 PM

@01tonythomas alright, I've overlooked that, thanks for the reminder :)

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Dec 1 2017, 9:00 PM
gerritbot added a comment.Dec 8 2017, 11:40 PM

Change 396548 had a related patch set uploaded (by Divadsn; owner: Divadsn):
[mediawiki/extensions/Newsletter@master] Replace instances of rawParams() to plaintextParams()

https://gerrit.wikimedia.org/r/396548

QuimGil awarded a token.Dec 9 2017, 8:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL