Page MenuHomePhabricator
Create Task
Maniphest T181002

Duplicate suggestion when a white space is added to the search criteria
Closed, ResolvedPublic
Actions

Assigned To
• Petar.petkovic
Authored By
Etonkovidova
Nov 20 2017, 9:47 PM
Tags
Referenced Files
F10906383: Screen Shot 2017-11-20 at 1.42.36 PM.png
Nov 20 2017, 9:51 PM
F10906391: Screen Shot 2017-11-20 at 1.42.49 PM.png
Nov 20 2017, 9:51 PM
F10856705: missing_English.mov
Nov 20 2017, 9:47 PM
F10857275: Screen Shot 2017-11-17 at 6.10.59 PM.png
Nov 20 2017, 9:47 PM
Subscribers
Aklapper
Catrope
Etonkovidova
gerritbot
• Petar.petkovic

Description

Split up from T178126: [1.31.0-wmf.3] False 'Missing in English' label is displayed for articles existing in enwiki as a separate issue:

Steps to reproduce:

  1. In 'New translation' box type some search criteria - e.g. Robot.
  2. The correct list of suggestions will be displayed. Press the spacebar to add a white space immediately after the search term 'Robot' - a strange entry for Robot article will be displayed with "Missing in English".

The screen recording shows that for catala->English suggested translations, Robot article becomes marked with "Missing in English" after adding a white space in the text field. When I click on it, I see "The article already exists in English".

missing_English.mov2 MBDownload

This extra article item appears with many search entries - e.g. Tor, Japan, Test. After clicking on such suggestion, you'll redirected to the article that was displayed below on the list.

Screen Shot 2017-11-17 at 6.10.59 PM.png (459×941 px, 78 KB)

The link associated with the extra item is exactly the same:

<div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-iconElement oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget mw-widget-titleOptionWidget mw-cx-widget-titleOptionWidget" aria-disabled="false" tabindex="-1" role="option" aria-selected="false" id="oojsui-8"><span class="oo-ui-iconElement-icon oo-ui-icon-page-existing"></span><a class="oo-ui-labelElement-label"** href="//ca.wikipedia.org/wiki/Robot_" **tabindex="-1" title="Robot">Robot</a><span class="oo-ui-indicatorElement-indicator"></span><span class="mw-cx-widget-titleOptionWidget-numOfLanguages"><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-iconElement oo-ui-iconElement-icon oo-ui-icon-language oo-ui-iconWidget" aria-disabled="false" title="Number of languages"></span><label class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-labelElement-label oo-ui-labelWidget" aria-disabled="false">1</label></span><span class="mw-cx-widget-titleOptionWidget-missing">Missing in English</span></div>

And for the below item, some image will be included:

<div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-iconElement oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget mw-widget-titleOptionWidget mw-cx-widget-titleOptionWidget" aria-disabled="false" tabindex="-1" role="option" aria-selected="false" id="oojsui-9"><span class="oo-ui-iconElement-icon oo-ui-icon-page-existing mw-widget-titleOptionWidget-hasImage" style="background-image: url(&quot;https://upload.wikimedia.org/wikipedia/commons/thumb/8/80/Paris_Air_Show_2007-06-24_n20.jpg/80px-Paris_Air_Show_2007-06-24_n20.jpg&quot;);"></span><a class="oo-ui-labelElement-label"** href="//ca.wikipedia.org/wiki/Robot" **tabindex="-1" title="Robot">Robot</a><span class="oo-ui-indicatorElement-indicator"></span><span class="mw-widget-titleOptionWidget-description" title="mechanical or virtual artificial agent">mechanical or virtual artificial agent</span><span class="mw-cx-widget-titleOptionWidget-numOfLanguages"><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-iconElement oo-ui-iconElement-icon oo-ui-icon-language oo-ui-iconWidget" aria-disabled="false" title="Number of languages"></span><label class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-labelElement-label oo-ui-labelWidget" aria-disabled="false">107</label></span></div>

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove duplicate suggestions in search resultsmediawiki/extensions/ContentTranslationmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Nov 20 2017, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2017, 9:47 PM
Etonkovidova renamed this task from Duplicate suggestion when a white spaces is added to Duplicate suggestion when a white space is added to the search criteria.Nov 20 2017, 9:48 PM
Etonkovidova added a subscriber: Catrope.Nov 20 2017, 9:51 PM

@Catrope suggested to check VE link inspector for the issue and he was right - the added white space to the search criteria will add a duplicate suggestion.

Screen Shot 2017-11-20 at 1.42.36 PM.png (315×418 px, 25 KB)

Add a white space to the search criteria - a duplicate suggestion appears:

Screen Shot 2017-11-20 at 1.42.49 PM.png (362×435 px, 27 KB)

Etonkovidova mentioned this in T178126: [1.31.0-wmf.3] False 'Missing in English' label is displayed for articles existing in enwiki .Nov 20 2017, 9:52 PM
• Petar.petkovic claimed this task.Nov 20 2017, 10:00 PM
• Petar.petkovic added a project: User-Petar.petkovic.
• Petar.petkovic subscribed.
In T181002#3776026, @Etonkovidova wrote:

@Catrope suggested to check VE link inspector for the issue and he was right - the added white space to the search criteria will add a duplicate suggestion.

Screen Shot 2017-11-20 at 1.42.36 PM.png (315×418 px, 25 KB)

Add a white space to the search criteria - a duplicate suggestion appears:

Screen Shot 2017-11-20 at 1.42.49 PM.png (362×435 px, 27 KB)

That is because VE link inspector and CX search input field use same OOJS UI widget in inheritance chain. I have already claimed this is inherited from the widget in T178126#3773611.
Thank you @Etonkovidova for filing this ticket and thank you @Catrope for you insight.

gerritbot subscribed.Nov 24 2017, 2:18 PM

Change 393231 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Remove duplicate suggestions in search results

https://gerrit.wikimedia.org/r/393231

gerritbot added a project: Patch-For-Review.Nov 24 2017, 2:18 PM
• Petar.petkovic edited projects, added Language-2017-Oct-Dec; removed User-Petar.petkovic.Nov 24 2017, 2:19 PM
• Petar.petkovic moved this task from Backlog to In Review on the Language-2017-Oct-Dec board.
Arrbee moved this task from Needs Triage to Oct-Dec 2017 on the ContentTranslation board.Nov 27 2017, 6:56 AM
gerritbot added a comment.Nov 29 2017, 7:13 PM

Change 393231 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Remove duplicate suggestions in search results

https://gerrit.wikimedia.org/r/393231

• Petar.petkovic moved this task from In Review to QA on the Language-2017-Oct-Dec board.Nov 29 2017, 7:48 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Nov 29 2017, 8:01 PM
Etonkovidova updated the task description. (Show Details)Nov 30 2017, 1:29 AM
Etonkovidova added a comment.Nov 30 2017, 1:37 AM

@Petar.petkovic I still see the issue in cx-testing - should it be tested somewhere else?

• Petar.petkovic added a comment.Nov 30 2017, 9:34 PM
In T181002#3798791, @Etonkovidova wrote:

@Petar.petkovic I still see the issue in cx-testing - should it be tested somewhere else?

I don't see the issue. Do you still see it? If so, what are you typing to get duplicate results?

Etonkovidova added a comment.Dec 1 2017, 11:57 PM

Yes, the issue is fixed (what I saw was possibly some cached search stuff). Closing the issue.

Etonkovidova closed this task as Resolved.Dec 1 2017, 11:58 PM
Nikerabbit removed a project: Patch-For-Review.Dec 2 2017, 11:03 AM
Nikerabbit moved this task from QA to Done on the Language-2017-Oct-Dec board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits