Page MenuHomePhabricator

Image metadata attributes produce invalid XML.
Closed, ResolvedPublic

Description

Image metadata properties are not validated for correct XML output.

As an example, the 'ALBUM ARTIST' property generate <comments ALBUM ARTIST="XX" /> which is not an attribute called ALBUM ARTIST, but an ARTIST attribute with another, ALBUM one without value (which is invalid).


Version: unspecified
Severity: enhancement
URL: http://commons.wikimedia.org/w/api.php?format=xml&action=query&prop=imageinfo&iiprop=metadata&titles=Image:Nl-Mexico.ogg

Details

Reference
bz16105

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:19 PM
bzimport added a project: MediaWiki-API.
bzimport set Reference to bz16105.

Another example, at Image:Nl-truc.ogg: <comments Comments="Wikimedia Foundation, Commons" Artist Name="[[meta:User:Walter]]" />

Damn, I hate XML.

Fixed in r42552 by replacing these spaces with underscores (only in XML, of course; other formats are unaffected).