Page MenuHomePhabricator
Create Task
Maniphest T181060

Cache constraint check results per-entity in ObjectCache (L) (days: 2)
Closed, ResolvedPublic
Actions

Description

This was split off from T179849: Cache all constraint check results per-entity: for now, we’ll start out with caching the results in memcached. That will already require us to solve the problem of invalidation, and migrating to the database for T180582: List of all constraint violations (see this comment) can then be done in the future. (Probably not by actually moving results from memcached to the database but just by starting to write to and read from the database instead.)

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+1 -0Enable caching of constraint check results
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLucas_Werkmeister_WMDET173695 Enable constraint checks by default for users
 OpenNoneT103228 Improve performance of constraint check
 ResolvedLydia_PintscherT179839 Cache constraint check results
 ResolvedLydia_PintscherT179849 Cache all constraint check results per-entity
 ResolvedLucas_Werkmeister_WMDET181060 Cache constraint check results per-entity in ObjectCache (L) (days: 2)
 ResolvedLucas_Werkmeister_WMDET181080 Add cacheable layer between CheckConstraints and DelegatingConstraintChecker
 ResolvedLucas_Werkmeister_WMDET182104 Track entities to consider when checking whether cached constraint check result is valid
 ResolvedLucas_Werkmeister_WMDET182105 Store constraint check results and tracked entities in object cache
 ResolvedLucas_Werkmeister_WMDET182106 Read constraint check results from cache and check freshness
 ResolvedLucas_Werkmeister_WMDET182107 Remove cached constraint check results on purge
 ResolvedLucas_Werkmeister_WMDET182992 Update 'cached' information when getting constraint check results from cache
 ResolvedLucas_Werkmeister_WMDET182994 Get entity revision IDs in bulk
 ResolvedLucas_Werkmeister_WMDET184062 Add tracking for constraint check result cache hits and misses
 ResolvedLucas_Werkmeister_WMDET184812 Enable constraint result caching on Wikidata
 ResolvedNoneT183927 Add parameter to only get violations from wbcheckconstraints (days: 1)
 ResolvedLucas_Werkmeister_WMDET184937 Change wbcheckconstraints’ status parameter’s default value to cacheable value
 InvalidNoneT185104 status parameter removes too many results
 ResolvedLucas_Werkmeister_WMDET185688 Constraint check results are cached independent of language
 ResolvedLucas_Werkmeister_WMDET185689 Add language to cache key for check results
 ResolvedLucas_Werkmeister_WMDET185709 Cache CheckResult serializations per-entity in ObjectCache
 ResolvedLucas_Werkmeister_WMDET185710 Introduce class for constraint violation messages
 ResolvedLucas_Werkmeister_WMDET185999 Make ViolationMessage serializable
 ResolvedLucas_Werkmeister_WMDET187186 Use ViolationMessage in ConstraintParameterException
 ResolvedLucas_Werkmeister_WMDET187199 Remove support for plain string messages from ViolationMessageRenderer
 ResolvedLucas_Werkmeister_WMDET187201 Remove message argument related parts of ConstraintParameterRenderer
 ResolvedLucas_Werkmeister_WMDET187202 Remove injected ConstraintParameterRenderer from checkers and helpers
 ResolvedLucas_Werkmeister_WMDET185711 Make Constraint serializable
 ResolvedLucas_Werkmeister_WMDET185712 Make Context serializable
 DeclinedNoneT185713 Make CheckResult status serializable
 ResolvedLucas_Werkmeister_WMDET185714 Make CheckResult serializable
 ResolvedLucas_Werkmeister_WMDET188629 Completely remove support for detail and detailHTML in wbcheckconstraints response
 ResolvedLucas_Werkmeister_WMDET189875 Migrate “exception” check results to ViolationMessage
 ResolvedLucas_Werkmeister_WMDET189593 Replace CachingResultsBuilder with CachingResultsSource, (de)serializing CheckResults
 OpenNoneT190672 Cache check results from Special:ConstraintReport checks
 ResolvedLucas_Werkmeister_WMDET190684 Serialize NullResults in CachingResultsSource
 ResolvedLucas_Werkmeister_WMDET187057 Constraint check results involving the current time are cached indiscriminately [M]
 ResolvedLucas_Werkmeister_WMDET187058 Introduce separate messages for range violations involving current time
 ResolvedLucas_Werkmeister_WMDET186008 Remove range in numerical notation from violation messages
 ResolvedLucas_Werkmeister_WMDET187061 Don’t cache constraint check results involving current time whose validity will change soon
 ResolvedLucas_Werkmeister_WMDET188311 Don’t pass empty entity ID lists to WikiPageMetaDataAccessor
 ResolvedLucas_Werkmeister_WMDET188312 Don’t pass overly long entity ID lists to WikiPageEntityDataAccessor
 ResolvedLucas_Werkmeister_WMDET188418 Deduplicate entity ID lists in DependencyMetadata
 ResolvedjcrespoT188505 Investigate why query killer didn't kill 1-hour long queries

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 21 2017, 3:10 PM
WMDE-leszek added a project: Wikidata-Sprint-2017-11-22.Nov 21 2017, 3:19 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 21 2017, 3:26 PM
Lucas_Werkmeister_WMDE mentioned this in T179849: Cache all constraint check results per-entity.Nov 21 2017, 4:16 PM
Lucas_Werkmeister_WMDE created subtask T181080: Add cacheable layer between CheckConstraints and DelegatingConstraintChecker.Nov 21 2017, 7:08 PM
Lucas_Werkmeister_WMDE created subtask T182104: Track entities to consider when checking whether cached constraint check result is valid.Dec 5 2017, 3:20 PM
Lucas_Werkmeister_WMDE created subtask T182105: Store constraint check results and tracked entities in object cache.
Lucas_Werkmeister_WMDE created subtask T182106: Read constraint check results from cache and check freshness.Dec 5 2017, 3:23 PM
Lucas_Werkmeister_WMDE created subtask T182107: Remove cached constraint check results on purge.
Lucas_Werkmeister_WMDE added a project: Wikidata-Former-Sprint-Board.Dec 5 2017, 3:40 PM
Lucas_Werkmeister_WMDE closed subtask T181080: Add cacheable layer between CheckConstraints and DelegatingConstraintChecker as Resolved.Dec 6 2017, 1:24 PM
• Jonas closed subtask T182104: Track entities to consider when checking whether cached constraint check result is valid as Resolved.Dec 11 2017, 12:52 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 11 2017, 6:01 PM
Lydia_Pintscher removed a project: Wikidata-Former-Sprint-Board.Dec 18 2017, 2:54 PM
Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.
Lucas_Werkmeister_WMDE mentioned this in T183159: Only invalidate cached constraint check results when property constraints are edited.Dec 18 2017, 5:19 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-03.Jan 2 2018, 2:24 PM
WMDE-leszek closed subtask T182992: Update 'cached' information when getting constraint check results from cache as Resolved.Jan 2 2018, 2:42 PM
WMDE-leszek closed subtask T182106: Read constraint check results from cache and check freshness as Resolved.
WMDE-leszek closed subtask T182107: Remove cached constraint check results on purge as Resolved.
Lydia_Pintscher closed subtask T182105: Store constraint check results and tracked entities in object cache as Resolved.Jan 2 2018, 2:50 PM
Lydia_Pintscher moved this task from needs discussion or investigation to in progress on the Wikidata board.
Lucas_Werkmeister_WMDE closed subtask T182994: Get entity revision IDs in bulk as Resolved.Jan 9 2018, 12:09 PM
Lucas_Werkmeister_WMDE closed subtask T184062: Add tracking for constraint check result cache hits and misses as Resolved.
gerritbot added a subscriber: gerritbot.Jan 9 2018, 4:49 PM

Change 403195 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Enable caching of constraint check results

https://gerrit.wikimedia.org/r/403195

gerritbot added a project: Patch-For-Review.Jan 9 2018, 4:49 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-03 board.Jan 9 2018, 4:53 PM
WMDE-leszek renamed this task from Cache constraint check results per-entity in ObjectCache (L) to Cache constraint check results per-entity in ObjectCache (L) (days: 2).Jan 11 2018, 9:35 AM
gerritbot added a comment.Jan 11 2018, 1:10 PM

Change 403195 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable caching of constraint check results

https://gerrit.wikimedia.org/r/403195

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 12 2018, 5:56 PM
Lucas_Werkmeister_WMDE claimed this task.

I’ve created T184812: Enable constraint result caching on Wikidata for the remaining bit, so closing this task.

WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2018-01-03 board.Jan 13 2018, 11:38 AM
Lucas_Werkmeister_WMDE mentioned this in T185122: Import constraint statements synchronously instead of via job?.Jan 17 2018, 5:44 PM
Lucas_Werkmeister_WMDE mentioned this in T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions).Jan 25 2018, 1:06 PM
Lucas_Werkmeister_WMDE mentioned this in T185709: Cache CheckResult serializations per-entity in ObjectCache.Jan 25 2018, 6:41 PM
Lucas_Werkmeister_WMDE closed subtask T184812: Enable constraint result caching on Wikidata as Resolved.Feb 26 2018, 2:28 PM
jcrespo reopened subtask T184812: Enable constraint result caching on Wikidata as Open.Feb 26 2018, 5:24 PM
Lucas_Werkmeister_WMDE closed subtask T184812: Enable constraint result caching on Wikidata as Resolved.Mar 12 2018, 5:29 PM
Lucas_Werkmeister_WMDE closed subtask T185688: Constraint check results are cached independent of language as Resolved.Mar 27 2018, 10:43 AM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL