Page MenuHomePhabricator

Merge on addresses for MG
Closed, ResolvedPublic2 Estimated Story Points

Description

if there are conflicts on address, use the newest address. This should be an expansion of the merge rules from the rest of civi.

Event Timeline

DStrine created this task.Nov 21 2017, 8:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2017, 8:17 PM

Change 394239 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Allow Major gift contacts with conflicting addresses to merge.

https://gerrit.wikimedia.org/r/394239

Change 395645 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Remove major-gifts specific dedupe code.

https://gerrit.wikimedia.org/r/395645

Change 394239 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Allow Major gift contacts with conflicting addresses to merge.

https://gerrit.wikimedia.org/r/394239

Change 395661 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@deployment] Allow Major gift contacts with conflicting addresses to merge.

https://gerrit.wikimedia.org/r/395661

Change 395645 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Remove major-gifts specific dedupe code.

https://gerrit.wikimedia.org/r/395645

Change 395661 merged by jenkins-bot:
[wikimedia/fundraising/crm@deployment] Allow Major gift contacts with conflicting addresses to merge.

https://gerrit.wikimedia.org/r/395661

I just ran this with the new merge rule & $500+ now has 150 dupes - it was 389, but I also discovered that it was being too timid about running (waiting for incoming donations to only be 50 per minute) & so had not run for a while. I made it more aggressive

Note this one
https://civicrm.wikimedia.org/civicrm/contact/merge?reset=1&cid=19920829&oid=23428085&action=update&rgid=13&criteria={}&limit=500000000&gid=268

is a cases where the contacts have the same email but in one case it is on hold & in the other we have been emailing the person!

@LeanneS @NNichols now merging on address conflicts - hopefully you are seeing less dupes?

@NNichols and @DKaufman Since you're doing the bulk of merges right now, could you confirm for @Eileenmcnaughton?

@Eileenmcnaughton Sorry for the delay! I have definitely noticed a decrease in dupes. I say we're good to close.

Eileenmcnaughton set the point value for this task to 2.Jun 27 2019, 5:18 AM