Page MenuHomePhabricator
Create Task
Maniphest T181102

[BUG] Fix search term highlighting on dark and sepia
Closed, ResolvedPublic
Actions

Description

How many times were you able to reproduce it?

Steps to reproduce

  1. Load article
  2. Switch to dark or sepia
  3. Search for a term in article

Expected results

Search results are highlighted

Actual results

Search results are not highlighted

Environments observed

App version:
5.8

OS versions:
All

Device model:
All

Device language:
All

Related Objects

Event Timeline

Mhurd created this task.Nov 21 2017, 10:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2017, 10:33 PM
Mhurd moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 21 2017, 10:33 PM

https://github.com/wikimedia/wikipedia-ios/pull/1942

Mhurd added a subscriber: cmadeo.Nov 21 2017, 10:36 PM

@cmadeo had a small tweak to the dark mode search highlight color so we tweaked that as part of this PR as well.

JoeWalsh mentioned this in rAPIOS643a1a9a8f50: Merge branch 'develop' into fix/search-highlight-dark-sepia/T181102.Nov 27 2017, 12:26 PM
JoeWalsh mentioned this in rAPIOS8f64098bc2b1: Merge pull request #1942 from wikimedia/fix/search-highlight-dark-sepia/T181102.
• JMinor triaged this task as Low priority.Nov 27 2017, 8:08 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
JoeWalsh moved this task from Needs Code Review to Needs QA on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 27 2017, 8:09 PM
Nicholas.tsg subscribed.Nov 27 2017, 9:38 PM

Testing on iPhone 6 Plus (iOS 11.1.2) - Wikipedia app 5.8.0 (1265). Search term results are now highlighted in dark and sepia modes according to the screencaps below.

T181102 Dark.PNG (2×1 px, 1 MB)
T181102 Sepia.PNG (2×1 px, 1 MB)

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 13 2017, 10:41 PM
ABorbaWMF subscribed.

Fixed on Wikipedia app 5.7.3 (1281) as well.

ABorbaWMF added a comment.Dec 13 2017, 10:42 PM

Fixed on Wikipedia app 5.7.3 (1281) as well.

• JMinor closed this task as Resolved.Jan 8 2018, 10:42 PM
• JMinor subscribed.

Checked that Black theme is also looking good.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL