Page MenuHomePhabricator

Mobile touch screen fingers zoom does not work
Closed, ResolvedPublic

Description

Hi. Thank you very much for the skin deployment, we waited so much. It's a great skin.
The issue is described in the title. Recognized on internal Lollipop browser. Thank you.

Event Timeline

TheDJ added a subscriber: TheDJ.

zoom in or zoom out ?

zooming in works for me on iOS. The viewport definition also seems correct:
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1"/>

Although I'd remove width=device-width these days, because it's bad on landscape views.

zoom in or zoom out ?

Both.

Jhernandez moved this task from Needs triage to Triaged on the Mobile board.Nov 24 2017, 11:17 AM

Doesn't appear to be specific to Android Lollipop as I can reproduce this on KitKat with the following browsers:

  • Chrome 33.0
  • Firefox 47.0
  • Internal browser (no idea about the name, let alone the version of this; appears to be ASUS' own fork of Chromium)

cc'ing @Isarra as the skin's main developer as well as @SamanthaNguyen for additional thoughts on this.

TheDJ added a comment.EditedNov 24 2017, 12:30 PM

we should probably add user-scalable=yes at the end of the viewport definition

Seems the defaults are all over the place with the various browser generations.

Right it also sets maximum-scale=1, so that basically means that zooming isn't allowed.

I think preventing zooming is bad (and iOS doesn't even allow to to block that any longer for website). I suggest we go with what minerva uses as well

initial-scale=1.0, user-scalable=yes, minimum-scale=0.25, maximum-scale=5.0, width=device-width

This allows zooming in and out, and I think that makes sense.

Change 393368 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/skins/Timeless@master] Allow viewport zooming

https://gerrit.wikimedia.org/r/393368

Change 393368 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Allow viewport zooming

https://gerrit.wikimedia.org/r/393368

Works great, thank you!

IKhitron closed this task as Resolved.Dec 14 2017, 12:04 AM
IKhitron assigned this task to TheDJ.