Download button showing on namespaces other than the main namespace
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	Nov 22 2017, 2:25 PM

Description

Background

In T177215: Build download button for mobile PDF download, a portion of the acceptance criteria was to only display the button on the article namespace. In implementation however we only excluded it from showing on the MAIN page but it still shows up in pages other than the main namespace and failed to pick up on this mistake within our process.

Acceptance criteria

only show the button when the namespace is 0 (NS_MAIN).
do not show button on main page

Steps to reproduce

Change has been enabled on https://reading-web-staging.wmflabs.org/
expected: no download button appears on main page
expected: download page only shows on main namespace e.g. not on pages such as Talk:Foo etc..

Details

	Subject	Repo	Branch	Lines +/-
	Disable download button in all namespaces except main	mediawiki/skins/MinervaNeue	master	+6 -3

Customize query in gerrit

Related Objects

Mentioned In: T180862: Download icon is confusing in file namespace
Mentioned Here: T177215: Build download button for mobile PDF download

Event Timeline

ovasileva created this task.Nov 22 2017, 2:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2017, 2:25 PM

ovasileva triaged this task as High priority.Nov 22 2017, 2:25 PM

ovasileva mentioned this in T180862: Download icon is confusing in file namespace.

Jdlrobson renamed this task from Download button showing on namespaces other than the article namespace to Download button showing on namespaces other than the MAIN namespace.Nov 22 2017, 3:55 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from Download button showing on namespaces other than the MAIN namespace to Download button showing on namespaces other than the main namespace.Nov 22 2017, 5:06 PM

ovasileva updated the task description. (Show Details)Nov 22 2017, 5:12 PM

ovasileva set the point value for this task to 2.Nov 22 2017, 5:15 PM

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Nov 22 2017, 5:42 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Nov 23 2017, 12:45 PM

Jdlrobson moved this task from Upcoming to 2017-18 Q2 on the Web-Team-Backlog board.Nov 27 2017, 8:32 PM

• Nirzar merged a task: T180862: Download icon is confusing in file namespace.Nov 28 2017, 10:04 AM

• Nirzar added subscribers: Jdlrobson, Platonides, • Nirzar, • Tbayer.

Change 393852 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Disable download button in all namespaces except main

https://gerrit.wikimedia.org/r/393852

gerritbot added a project: Patch-For-Review.Nov 28 2017, 9:17 PM

Fix was trivial ^

Jdlrobson claimed this task.Nov 29 2017, 12:22 AM

I'm against hardcoding this kind of stuff in the code. I'm more than sure that after deploying that to production we will get many questions why download button is not available on some pages.

I would introduce a config variable, it doesn't hurt us, overhead is minimal, and it gives us flexibility. Also we could get read of "on/off" toggle just pass an empty namespaces array

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Nov 29 2017, 5:38 PM

Jdlrobson moved this task from Needs More Work to Doing on the Readers-Web-Kanbanana-Board-Old board.Nov 29 2017, 7:03 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Nov 29 2017, 7:28 PM

New patchset is up, repurposing the existing config flag.

Looks good, there are some issues with selenium tests not related to that task. I'll keep my eye on the Jenkins results and move task to needs QA when the patch gets merged

pmiazga removed a project: Patch-For-Review.Nov 29 2017, 9:58 PM

Change 393852 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Disable download button in all namespaces except main

https://gerrit.wikimedia.org/r/393852

pmiazga moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Nov 29 2017, 10:49 PM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Nov 29 2017, 11:00 PM

Over to you Anthony.

Jdlrobson updated the task description. (Show Details)Nov 30 2017, 12:06 AM

Jdlrobson updated the task description. (Show Details)

I found this page on Staging. I don't know if it counts as a namespace, but there is no print button present.

Ready for signoff as per @Jdlrobson

all done!

	F11178464: ns pahe2.png
	Dec 4 2017, 5:48 PM

	F11178465: ns-page1.png
	Dec 4 2017, 5:48 PM

Download button showing on namespaces other than the main namespaceClosed, ResolvedPublic2 Estimated Story PointsActions