To navigate on the Recent Changes page, you can use the keyboard to access quickly some specific navigation links.
How to:
- load Recent Changes page on fr.wp or de.wp (not en.wp where the case can't be reproduced)
- press Tab
Expectation:
Reality:
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/core | master | +5 -0 | Fix jump-to-nav element overlap on RCFilters |
Related Objects
Related Objects
Event Timeline
Comment Actions
What is #jump-to-nav? It must be something you add somehow, since I don't see it on fr or de.
Comment Actions
Yes, the element is present, but not in UI (unless not on my screen. Some gadget needs to be enabled?):
<div id="jump-to-nav" class="mw-jump"> Jump to: <a href="#mw-head">navigation</a>, <a href="#p-search">search</a> </div>
Comment Actions
We see this on French but not English, for example. Why? What customization did French do to the page?
Comment Actions
During the bug triage meeting the bug was confirmed - the issue exists on Watchlist too (RelatedChanges page seems to be ok).
Comment Actions
I see those links when I use Tab keyboard as described in the task description.
As described on the task, the issue is true for fr and also de. I've tried again on Spanish Wikipedia, and I have that issue there as well.
You should question the opposite here: what customization did English Wikipedia not to have those links. :)
Comment Actions
Change 403203 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] Fix jump-to-nav element overlap on RCFilters
Comment Actions
You are right, sir. Because of T178626, following code was added to Common.css file on enwiki:
/* T178626 */
#contentSub:empty,
#contentSub2:empty {
display: block !important;
}
#contentSub:empty ~ #jump-to-nav,
#contentSub2:empty ~ #jump-to-nav {
margin-top: -1.4em !important;
margin-bottom: 1.4em !important;
}which makes this bug not appear on enwiki, although the reason for adding this piece of code was different issue.
Comment Actions
English Wikipedia hack is added for different reasons than what's described in this ticket, but affects RC pages as well, making navigation not overlapping with the title.
I have provided solution with enwiki and all other wikis in mind, so nothing breaks because of custom overrides afterwards.
Comment Actions
If you need to change English Wikipedia's CSS, because of any good reason (conflict with your patch, redundancy...) that will not affect their experience, that's possible.
Comment Actions
Change 403203 merged by jenkins-bot:
[mediawiki/core@master] Fix jump-to-nav element overlap on RCFilters
