Page MenuHomePhabricator

AdvancedSearch breaks usability of mobile search by pushing search results down page
Closed, ResolvedPublic

Description

The new advanced search makes searching a pain on mobile, as the namespace filters push search results further down the page

https://m.mediawiki.org/w/index.php?title=Special:Search&search=ElectronPdf

Ideally this would be accessible via some kind of button as most of the time I do not care about that filter form. It should be hidden by default.

Screenshot_20171122-092518.png (2×1 px, 170 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 392883 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/AdvancedSearch@master] Remove unneeded hook for search profiles

https://gerrit.wikimedia.org/r/392883

WMDE-Fisch added subscribers: thiemowmde, WMDE-Fisch.

Thanks for the bug report. For the moment being we do not intend to touch the mobile view yet. But confusingly the issue seems to be connected to us hooking into SpecialSearchProfiles. ( also the only place that had no check for an enabled beta feature -.- ). After some research in code and asking one of the main authors of the extension, I figured that this hook might be unnecessary and uploaded the attached patch. Additional confirmation by @thiemowmde would be great though.

Change 392883 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Remove hook to clear search profiles

https://gerrit.wikimedia.org/r/392883

Change 393568 had a related patch set uploaded (by Addshore; owner: WMDE-Fisch):
[mediawiki/extensions/AdvancedSearch@wmf/1.31.0-wmf.8] Remove hook to clear search profiles

https://gerrit.wikimedia.org/r/393568

Change 393568 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@wmf/1.31.0-wmf.8] Remove hook to clear search profiles

https://gerrit.wikimedia.org/r/393568

Mentioned in SAL (#wikimedia-operations) [2017-11-27T14:10:34Z] <addshore@tin> Synchronized php-1.31.0-wmf.8/extensions/AdvancedSearch: SWAT AdvancedSearch T181175 T181222, adjust links in beta section & fix usability of mobile search (duration: 00m 46s)