Page MenuHomePhabricator
Create Task
Maniphest T181186

Timeless list does not recognize empty items
Closed, ResolvedPublic
Actions

Description

Hello. The .mw-empty-elt style does not work properly on Timeless. The line still appears, with no text. Thank you.

Details

SubjectRepoBranchLines +/-
Hide empty list itemsmediawiki/skins/Timelessmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

IKhitron created this task.Nov 22 2017, 6:32 PM
Izno added a subscriber: Izno.Nov 22 2017, 6:35 PM

There are some similar tasks in this search.

IKhitron added a comment.Nov 22 2017, 6:38 PM
In T181186#3782263, @Izno wrote:

There are some similar tasks in this search.

Indeed, but the search becomes empty when adding Timeless.

IKhitron added a subscriber: Isarra.Nov 27 2017, 12:49 PM

Look. @Isarra:

Untitled.png (823×1 px, 109 KB)

Isarra added a comment.Dec 2 2017, 4:11 AM

Huh, okay. Support clearly needs to be added.

Izno mentioned this in T50079: Tidy: Numbered list markup with <pre> inbetween creates empty first bullet after <pre> section.Aug 16 2018, 5:01 PM
Izno mentioned this in T192446: Skins render differently with templates returning an initial asterisk .Aug 17 2018, 12:06 AM
Izno moved this task from Backlog to Change CSS on the CSS board.Sep 7 2018, 4:47 PM
Jc86035 added a subscriber: Jc86035.Nov 10 2018, 11:15 AM
zypA13510 mentioned this in T216224: Timeless skin causes superfluous empty item to appear in ordered lists.Feb 15 2019, 5:48 AM
zypA13510 merged a task: T216224: Timeless skin causes superfluous empty item to appear in ordered lists.Feb 15 2019, 5:51 AM
zypA13510 added a subscriber: zypA13510.
Izno merged a task: T218976: Extra "1." in lists that contains a table.Mar 22 2019, 1:27 PM
Izno added a subscriber: Pamputt.
Izno added a parent task: T192446: Skins render differently with templates returning an initial asterisk .Mar 22 2019, 1:31 PM
gerritbot added a comment.Apr 17 2019, 8:23 PM

Change 504766 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Hide empty list items

https://gerrit.wikimedia.org/r/504766

gerritbot added a project: Patch-For-Review.Apr 17 2019, 8:23 PM
gerritbot added a comment.Apr 18 2019, 12:23 AM

Change 504766 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Hide empty list items

https://gerrit.wikimedia.org/r/504766

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 18 2019, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:59 PM
Isarra closed this task as Resolved.May 27 2019, 6:52 AM
Isarra claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL