Make ORES-consuming pages more robust to ORES errors
Closed, ResolvedPublic
Actions

Description

All pages hooked by Extension:ORES need to be robust to any type of ORES failure, short of a PHP fatal error. We should gracefully degrade functionality, removing ORES features if they are broken or unavailable.

Handle:

~~Thresholds response contains a null.~~
Thresholds response malformed in an unexpected way.
~~ORES service is unreachable.~~
ORES service returns a 500.

Must have tests covering these cases.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Warn instead of throwing error in case threshold is unparseable	mediawiki/extensions/ORES	wmf/1.31.0-wmf.8	+10 -10
	Warn instead of throwing error in case threshold is unparseable	mediawiki/extensions/ORES	master	+10 -10

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	awight	T181010 [Spike] Write reports about why Ext:ORES is helping cause server 500s and write tasks to fix
Resolved	Ladsgroup	T184938 Special:RecentChanges broken on Jenkins slaves
Resolved	awight	T181191 Make ORES-consuming pages more robust to ORES errors

Event Timeline

awight created this task.Nov 22 2017, 7:03 PM

awight updated the task description. (Show Details)Nov 22 2017, 7:24 PM

awight added a project: Wikimedia-Incident.Nov 22 2017, 7:26 PM

awight moved this task from Active investigation to Follow-up prevention on the Wikimedia-Incident board.

Change 393373 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Warn instead of throwing error in case threshold is unparseable

https://gerrit.wikimedia.org/r/393373

gerritbot added a project: Patch-For-Review.Nov 25 2017, 2:01 PM

Change 393373 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Warn instead of throwing error in case threshold is unparseable

https://gerrit.wikimedia.org/r/393373

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 27 2017, 2:00 PM

Halfak moved this task from Parked to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Nov 27 2017, 3:06 PM

Change 393660 had a related patch set uploaded (by Awight; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@wmf/1.31.0-wmf.8] Warn instead of throwing error in case threshold is unparseable

https://gerrit.wikimedia.org/r/393660

Change 393660 merged by jenkins-bot:
[mediawiki/extensions/ORES@wmf/1.31.0-wmf.8] Warn instead of throwing error in case threshold is unparseable

https://gerrit.wikimedia.org/r/393660

Mentioned in SAL (#wikimedia-operations) [2017-11-27T21:23:38Z] <awight@tin> Synchronized php-1.31.0-wmf.8/extensions/ORES: ORES error handling for bad thresholds, T181191 (duration: 00m 46s)