Page MenuHomePhabricator

Horizon: editing hiera clears role params
Closed, ResolvedPublic

Description

The Horizon puppettab tries to do clever things with assigning certain hiera values to the roles that use the params. This mostly works, but when raw hiera is set the puppet tab forgets about all that and wipes out any hiera settings that aren't explicitly set in the free-form edit field.

Event Timeline

Change 392939 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Horizon puppet: Merge role-associated hiera values with freeform hiera

https://gerrit.wikimedia.org/r/392939

Change 392939 merged by Andrew Bogott:
[operations/puppet@production] Horizon puppet: Merge role-associated hiera values with freeform hiera

https://gerrit.wikimedia.org/r/392939

Change 392980 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] horizon pupettab: Handle the user passing in an empty hiera block

https://gerrit.wikimedia.org/r/392980

Change 392980 merged by Andrew Bogott:
[operations/puppet@production] horizon pupettab: Handle the user passing in an empty hiera block

https://gerrit.wikimedia.org/r/392980

I think this is fixed.