Page MenuHomePhabricator

Can't find Twinkle in Timeless skin
Closed, InvalidPublic

Description

I've got Twinkle turned on as a gadget (I have a few others as gadgets that would live in the relatively same place in Vector as Twinkle).

Where's the twinkle? :]

I would guess it's related to the code block at

// now some skin dependent config.
if ( mw.config.get( "skin" ) === "vector" ) {
	Twinkle.defaultConfig.twinkle.portletArea = "right-navigation";
	Twinkle.defaultConfig.twinkle.portletId   = "p-twinkle";
	Twinkle.defaultConfig.twinkle.portletName = "TW";
	Twinkle.defaultConfig.twinkle.portletType = "menu";
	Twinkle.defaultConfig.twinkle.portletNext = "p-search";
} else {
	Twinkle.defaultConfig.twinkle.portletArea =  null;
	Twinkle.defaultConfig.twinkle.portletId   = "p-cactions";
	Twinkle.defaultConfig.twinkle.portletName = null;
	Twinkle.defaultConfig.twinkle.portletType = null;
	Twinkle.defaultConfig.twinkle.portletNext = null;
}

in the Javascript file not having the best default, so what is the edit I should suggest at the Twinkle talk page? Or, alternatively, is this a Timeless problem?

Event Timeline

Izno created this task.Nov 23 2017, 2:47 AM
Legoktm renamed this task from Where the heck is Twinkle? to Can't find Twinkle in Timeless skin.Nov 23 2017, 6:39 AM
TTO added a subscriber: TTO.Nov 23 2017, 11:17 AM

It's really a Twinkle problem, unless you count the fact that Timeless doesn't use the same HTML IDs as Monobook as a Timeless problem (which I don't).

You can actually override those default settings in your personal Twinkle configuration file. I wonder what would happen if you created Special:MyPage/twinkleoptions.js with

// twinkleoptions.js: personal Twinkle preferences file
//
// NOTE: The easiest way to change your Twinkle preferences is by using the
// Twinkle preferences panel, at [[Wikipedia:Twinkle/Preferences/debug]].
//
// This file is AUTOMATICALLY GENERATED.  Any changes you make (aside from
// changing the configuration parameters in a valid-JavaScript way) will be
// overwritten the next time you click "save" in the Twinkle preferences
// panel.  If modifying this file, make sure to use correct JavaScript.

window.Twinkle.prefs = {
  "twinkle": {
    "portletId": "p-pagetools"
  }
};

// End of twinkleoptions.js

? That way youshould hopefully at least be able to see Twinkle even if it's not very pretty. Or you could try replacing p-pagetools with p-namespaces - let me know which effect you prefer.

Izno added a comment.Nov 23 2017, 12:01 PM

I will take a look.

This will break other gadgets also (as I mentioned, I have others that target that same bar that TW sits in).

Izno added a comment.EditedNov 23 2017, 10:02 PM

@TTO Marginal preference for p-pagetools. "Best case" IMO would be a dropdown like Vector. In either, Twinkle disappears at really small resolution (when everything turns to icons), so it should probably get a dropdown at some point (if that's possible). (Alternatively, that may indicate a separate problem. :D)

For now, I'll put it in p-pageactions.

Which actually doesn't work for pages where there isn't another page action? (e.g. full-move-protection).

TTO closed this task as Invalid.Nov 24 2017, 12:08 AM

As this is a Twinkle issue I have migrated it to the Twinkle issue tracker: https://github.com/azatoth/twinkle/issues/401

I've marked this task "invalid", not because the issue at hand is invalid, but purely as an administrative matter to show that this task relates to an issue that is not tracked in Phabricator.

Izno added a comment.Nov 24 2017, 12:15 AM

As this is a Twinkle issue I have migrated it to the Twinkle issue tracker: https://github.com/azatoth/twinkle/issues/401
I've marked this task "invalid", not because the issue at hand is invalid, but purely as an administrative matter to show that this task relates to an issue that is not tracked in Phabricator.

No worries--was pretty sure it was a twinkle thing.