Page MenuHomePhabricator

[BUG] Fix scrolling to next find-in-page result no longer vertically centering the next result
Closed, ResolvedPublic

Description

How many times were you able to reproduce it?

Each time

Steps to reproduce

  1. Load an article
  2. Tap the find in page icon
  3. Search for a term which appears more than once in the article
  4. Tap the up or down arrow to cycle between search results
  5. Also repeat these steps after having scrolled down a bit in the article so the navigation bar is hidden

Expected results

When a next result is scrolled to it is vertically centered between the top of the keyboard and the top of the article view

Actual results

When a next result is scrolled to it is not vertically centered between the top of the keyboard and the top of the article view

Screenshots

Environments observed

App version:
5.8

OS versions:
All

Device model:
All

Device language:
All

Event Timeline

Mhurd renamed this task from [BUG] Fix scrolling to next find in page result no longer centering the next result to [BUG] Fix scrolling to next find-in-page result no longer centering the next result.Nov 23 2017, 7:50 AM
Mhurd renamed this task from [BUG] Fix scrolling to next find-in-page result no longer centering the next result to [BUG] Fix scrolling to next find-in-page result no longer vertically centering the next result.

Testing on iPhone 6 Plus (iOS 11.1.2) - Wikipedia app 5.8.0 (1265). This is working as expected according to the video attached.

ABorbaWMF added a subscriber: ABorbaWMF.

Fixed on Wikipedia app 5.7.3 (1281) as well.