Page MenuHomePhabricator
Create Task
Maniphest T181228

Display titles with italics show as HTML
Closed, ResolvedPublic
Actions

Description

For example, page 1 sets a display title:

This is the {{DISPLAYTITLE:Display ''title''}} of this page.

and page 2 uses it:

and what is the title of [[DisplayTitle]]?

And it displays as:

and what is the title of Display <i>title</i>?

I've started a patch https://gerrit.wikimedia.org/r/#/c/393057/ for this, but haven't solved the problem at all, just written a test for it.

Details

SubjectRepoBranchLines +/-
Fix HTML formatting in title.mediawiki/extensions/DisplayTitlemaster+80 -6
Customize query in gerrit

Related Objects

Event Timeline

Samwilson created this task.Nov 23 2017, 12:28 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptNov 23 2017, 12:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Nov 23 2017, 12:28 PM

Change 393057 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/DisplayTitle@master] Add test for italics in title

https://gerrit.wikimedia.org/r/393057

gerritbot added a project: Patch-For-Review.Nov 23 2017, 12:28 PM
Samwilson mentioned this in rEDPTeb1f637cca21: Add test for italics in title.Nov 23 2017, 12:29 PM
Izno subscribed.Nov 23 2017, 1:52 PM
This comment was removed by Izno.
cicalese mentioned this in rEDPT792a20302c7a: Fix HTML formatting in title..Nov 23 2017, 2:26 PM
CCicalese_WMF subscribed.Nov 23 2017, 2:27 PM

Thank you for reporting this! I just added some code to fix this to your patch.

gerritbot added a comment.Nov 24 2017, 12:35 PM

Change 393057 merged by Cicalese:
[mediawiki/extensions/DisplayTitle@master] Fix HTML formatting in title.

https://gerrit.wikimedia.org/r/393057

Izno unsubscribed.Nov 24 2017, 12:56 PM
CCicalese_WMF closed this task as Resolved.Nov 24 2017, 1:37 PM
CCicalese_WMF claimed this task.
cicalese moved this task from Backlog to Closed on the MediaWiki-extensions-DisplayTitle board.Jan 11 2018, 3:15 PM
cicalese removed a project: Patch-For-Review.
cicalese claimed this task.Jan 11 2018, 3:18 PM
cicalese edited subscribers, added: cicalese; removed: CCicalese_WMF.
Kghbln mentioned this in rEDPT8867321702d4: Update patch set 6.Jun 9 2018, 11:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits