Page MenuHomePhabricator

Content after reference tag in template disappears
Closed, ResolvedPublic

Description

{{echo|Foo <references/> bar}}

Doesn't render 'bar' if it is on the same line (where Template:Echo is equal to {{{1}}})

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2017, 12:35 PM

Possibly related to about group re-parenting (T176425).

{{echo|<references/> bar}} incorrectly puts the about group on the <ol>, not the <div> wrapper, whereas {{echo|Foo <references/>}} works correctly.

Arlolra claimed this task.Nov 27 2017, 3:32 PM
Arlolra triaged this task as Normal priority.

Possibly related to about group re-parenting (T176425).

This disappearing "bar" predates the whole responsive references wrapper thing.

{{echo|<references/> bar}} incorrectly puts the about group on the <ol>, not the <div> wrapper, whereas {{echo|Foo <references/>}} works correctly.

The about grouping is correctly placed on the <div>. There's an additional, different about attribute on the nested <ol> for "clean semantic output". See the comment at https://github.com/wikimedia/parsoid/blob/master/lib/ext/Cite/index.js#L581-L592

Change 393634 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T181229: Stop adding packing wrappers for last nodes

https://gerrit.wikimedia.org/r/393634

Change 393634 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T181229: Stop adding packing wrappers for last nodes

https://gerrit.wikimedia.org/r/393634

Arlolra closed this task as Resolved.Nov 27 2017, 8:11 PM