Page MenuHomePhabricator
Create Task
Maniphest T181234

Scroll to selected field when changing the address or payment type
Closed, ResolvedPublic
Actions

Description

Description:
When I want to donate as a “Firma” on my mobile device, the form fields do not appear in the current viewport but above it. So I need to scroll up again. (The same applies for the option “Anonym”).

This also occurs when changing the payment type. In this case, it only really affects the usability when switching from direct debit to something else.

Browser: Chrome 62
Browser window width: 980
Browser window height: 1644
Viewport width: 393
Viewport height: 786
Screenshot: F10957266

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT177929 Integrate new layout
 ResolvedNoneT177930 donate - Integrate new layout
 ResolvedNoneT181234 Scroll to selected field when changing the address or payment type

Event Timeline

BullerMia created this task.Nov 23 2017, 1:26 PM
kai.nissen renamed this task from When I want to donate as a “Firma” on my mobile device, the text fields do not appear in my current viewport but above it to Scroll to selected field when changing the address or payment type.Nov 23 2017, 2:37 PM
kai.nissen removed • Pablo-WMDE as the assignee of this task.
kai.nissen removed a project: WMDE-Fundraising-Sprint-13.
kai.nissen updated the task description. (Show Details)
kai.nissen updated the task description. (Show Details)
• Pablo-WMDE moved this task from Backlog to Ready on the WMDE-Fundraising-Funban-2 board.Nov 29 2017, 3:08 PM
• Pablo-WMDE claimed this task.Nov 29 2017, 3:41 PM
• Pablo-WMDE moved this task from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
• Pablo-WMDE mentioned this in T180690: Show summarizing sentence after entering the donation form from a deep-link.Nov 29 2017, 4:25 PM
• Pablo-WMDE removed • Pablo-WMDE as the assignee of this task.Nov 29 2017, 4:42 PM
• Pablo-WMDE moved this task from Doing to Ready on the WMDE-Fundraising-Funban-2 board.
gabriel-wmde mentioned this in T181273: mobile device - button “Spende abschließen” is displayed twice.Nov 30 2017, 2:48 PM
gabriel-wmde claimed this task.Dec 1 2017, 8:40 AM
gabriel-wmde moved this task from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
• Pablo-WMDE added a comment.EditedDec 1 2017, 9:50 AM
// SuboptionDisplayHandler
if ( field.is( ':focus' ) ) {
   scrollTo( infoText );
}
gabriel-wmde added a comment.Dec 4 2017, 10:23 AM

PR in https://github.com/wmde/FundraisingFrontend/pull/1067

gabriel-wmde removed gabriel-wmde as the assignee of this task.Dec 4 2017, 10:24 AM
gabriel-wmde moved this task from Doing to Review on the WMDE-Fundraising-Funban-2 board.
• Pablo-WMDE added a comment.Dec 4 2017, 1:46 PM

Deployed to test https://test-spenden-2.wikimedia.de/?skin=cat17

• Pablo-WMDE moved this task from Review to Test on the WMDE-Fundraising-Funban-2 board.Dec 4 2017, 1:46 PM
kai.nissen added a comment.Dec 5 2017, 2:18 PM

Looks good in general. Two issues, though:

  • This should also be applied to the payment type options.
  • When changing the address type to 'company' on wide screens, the view (of course) also scrolls to the option field. The company name field is not visible in these cases, which feels confusing.
kai.nissen moved this task from Test to Ready on the WMDE-Fundraising-Funban-2 board.Dec 14 2017, 2:02 PM

The second one of my comments above has been fixed, but the first regarding the payment type options is not.

gabriel-wmde claimed this task.Dec 14 2017, 6:06 PM
gabriel-wmde moved this task from Ready to Doing on the WMDE-Fundraising-Funban-2 board.
• Pablo-WMDE added a comment.Dec 15 2017, 11:11 AM

PR https://github.com/wmde/FundraisingFrontend/pull/1120

• Pablo-WMDE removed gabriel-wmde as the assignee of this task.Dec 15 2017, 11:12 AM
• Pablo-WMDE moved this task from Doing to Review on the WMDE-Fundraising-Funban-2 board.
• Pablo-WMDE added a comment.Dec 15 2017, 3:07 PM

Available on https://test-spenden-2.wikimedia.de/?skin=cat17

• Pablo-WMDE moved this task from Review to Test on the WMDE-Fundraising-Funban-2 board.Dec 15 2017, 3:07 PM
• Pablo-WMDE moved this task from Test to Done on the WMDE-Fundraising-Funban-2 board.Dec 18 2017, 9:15 AM
kai.nissen closed this task as Resolved.Jan 5 2018, 1:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL