Page MenuHomePhabricator

IPA is not properly removed in link previews
Closed, ResolvedPublic


IPA templates (without brackets) are not properly removed in link previews. They leave an extra space.

Example: pagelink preview

Example 2: pagelink preview

Brackets, on the other hand, are properly removed, and no space is left.

Please fix this by setting Hovercards to remove the space before an IPA template.

Event Timeline

Jdlrobson subscribed.

We're in the process of moving this code to a new summary service which does not have this problem in T113094. Thanks for reporting this! It helps to have examples where the current summaries are broken!

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).
Jdlrobson added a subscriber: ABorbaWMF.

We should verify this is fixed. @ABorbaWMF can you help?

ovasileva subscribed.

It seems we can't test this on the beta cluster, but let's check it after we deploy html previews everywhere

This can be tested on production now as the summary endpoint is live everywhere. We don't need to turn on html previews to test this as the bug report is based on text previews (also in the case of whitespace text and html are identical).

@Jdlrobson - you're right, I wasn't thinking. looks fixed:

Screen Shot 2018-02-26 at 5.39.09 PM.png (564×433 px, 291 KB)

Pulling into current sprint. Not sure if this needs QA or signing off...

looks good - thanks all!