Noticed this while fixing the statsd check with https://gerrit.wikimedia.org/r/#/c/393607/ . I'm guessing the reason only integers are supported is because of bash arithmetic, though we should be able to check floats too. Bonus points if the patch is upstream-able!
Description
Description
Details
Details
Related Changes in Gerrit:
Event Timeline
Comment Actions
Change 409054 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] WIP: check prometheus metric
Comment Actions
Change 409054 merged by Filippo Giunchedi:
[operations/puppet@production] prometheus: add check prometheus metric script
Comment Actions
Change 413142 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] nagios_common: switch to check_prometheus_metric Python implementation
Comment Actions
Change 413142 merged by Filippo Giunchedi:
[operations/puppet@production] nagios_common: switch to check_prometheus_metric Python implementation
Comment Actions
This is complete, the python version has been deployed. From eyeballing the "nice" cpu % on einstenium I'd say it went from 12-13 to 15-16 so a 3% increase.