Puppet 4.x breaks the role/profile filters on Horizon
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Andrew
	Nov 28 2017, 6:59 PM

Description

After I made our puppetmasters environment-aware (https://gerrit.wikimedia.org/r/#/c/393677/) the puppet tab stopped loading because the puppet REST api couldn't find the 'puppet' environment.

I fixed this with https://gerrit.wikimedia.org/r/#/c/393819/ but now none of the filter tags are getting loaded -- apparently with environments the code comments aren't provided.

This needs fixing, but maybe can wait until after the 4.x upgrade since everything will no doubt break or change again as soon as we switch over.

Details

	Subject	Repo	Branch	Lines +/-
	Horizon puppet tab: disable role filters for now	operations/puppet	production	+6 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T211029 Sort out only one ideal hiera mechanism for Cloud VPS
Resolved	Andrew	T149589 Puppet tab in Horizon unusably slow
Stalled	None	T235708 Redesign for wmcs custom puppet settings
Resolved	Andrew	T181551 Puppet 4.x breaks the role/profile filters on Horizon

Event Timeline

Andrew created this task.Nov 28 2017, 6:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2017, 6:59 PM

Paladox subscribed.Nov 28 2017, 7:07 PM

Just a note to talk about this arena at our offsite next week :)

https://tickets.puppetlabs.com/browse/PUP-4973?jql=text%20~%20%22resource_type%20endpoint%22

It looks like the puppetlabs people accidentally broke this feature and aren't going to fix it ever. So we need some totally other path for filtering/documenting classes if this UI endures :(

bd808 subscribed.Dec 22 2017, 12:34 AM

Change 401506 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] Horizon puppet tab: disable role filters for now

https://gerrit.wikimedia.org/r/401506

gerritbot added a project: Patch-For-Review.Jan 2 2018, 2:28 PM

Change 401506 merged by Andrew Bogott:
[operations/puppet@production] Horizon puppet tab: disable role filters for now

https://gerrit.wikimedia.org/r/401506

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:58 PM

Andrew added a parent task: T235708: Redesign for wmcs custom puppet settings.Oct 23 2019, 3:24 PM