Page MenuHomePhabricator
Create Task
Maniphest T181565

Call to a member function bitAnd() on a non-object (null) in LogPager, so Special:Log doesn't work
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted in production: Call to a member function bitAnd() on a non-object (null)

Urls look like: /wiki/Special:Log/...

Stacktrace:

#0 /srv/mediawiki/php-1.31.0-wmf.10/includes/logging/LogPager.php(186): LogPager->enforcePerformerRestrictions()
#1 /srv/mediawiki/php-1.31.0-wmf.10/includes/logging/LogPager.php(79): LogPager->limitPerformer(string)
#2 /srv/mediawiki/php-1.31.0-wmf.10/includes/specials/SpecialLog.php(183): LogPager->__construct(LogEventsList, string, string, string, boolean, array, NULL, NULL, string, string)
#3 /srv/mediawiki/php-1.31.0-wmf.10/includes/specials/SpecialLog.php(109): SpecialLog->show(FormOptions, array)
#4 /srv/mediawiki/php-1.31.0-wmf.10/includes/specialpage/SpecialPage.php(522): SpecialLog->execute(string)
#5 /srv/mediawiki/php-1.31.0-wmf.10/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(string)
#6 /srv/mediawiki/php-1.31.0-wmf.10/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#7 /srv/mediawiki/php-1.31.0-wmf.10/includes/MediaWiki.php(851): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.31.0-wmf.10/includes/MediaWiki.php(523): MediaWiki->main()
#9 /srv/mediawiki/php-1.31.0-wmf.10/index.php(43): MediaWiki->run()
#10 /srv/mediawiki/w/index.php(3): include(string)
#11 {main}

Details

SubjectRepoBranchLines +/-
Fix undefined $dbmediawiki/coremaster+2 -2
Fix undefined $dbmediawiki/corewmf/1.31.0-wmf.10+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• demon created this task.Nov 28 2017, 9:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2017, 9:14 PM
• demon added a parent task: T178637: 1.31.0-wmf.10 deployment blockers.Nov 28 2017, 9:14 PM
Jdforrester-WMF subscribed.EditedNov 28 2017, 10:40 PM

Is that's what's causing Internal error: [Wh3lgQpAAEEAABx4NOIAAABL] 2017-11-28 22:38:57: Fatal exception of type "BadMethodCallException" on e.g. https://www.mediawiki.org/wiki/Special:Log/Foo ?

Jdforrester-WMF added a comment.Nov 28 2017, 10:42 PM

ce881e02e8d69839c0edfdd11fdec570a46ab506 looks suspect.

• demon added a comment.Nov 28 2017, 10:43 PM
In T181565#3794661, @Jdforrester-WMF wrote:

Is that's what's causing Internal error: [Wh3lgQpAAEEAABx4NOIAAABL] 2017-11-28 22:38:57: Fatal exception of type "BadMethodCallException" on e.g. https://www.mediawiki.org/wiki/Special:Log/Foo ?

Yep that's it

Jdforrester-WMF renamed this task from Call to a member function bitAnd() on a non-object (null) in LogPager to Call to a member function bitAnd() on a non-object (null) in LogPager, so Special:Log doesn't work.Nov 28 2017, 10:50 PM

Probably higher than Normal then. :-(

• demon raised the priority of this task from Medium to High.Nov 28 2017, 10:55 PM

Yeah, good point. Should just be a straight revert?

Jdforrester-WMF added a comment.Nov 28 2017, 11:20 PM

Reading the commit I can't quite see how it breaks, however.

• demon added subscribers: Cenarium, Krinkle.Nov 29 2017, 12:02 AM

Adding author and committer from that change. Thoughts?

Reedy merged a task: T181585: Testwiki Internal error: Call to a member function bitAnd() on a non-object (null).Nov 29 2017, 12:13 AM
Reedy added a project: MediaWiki-General.
Reedy added a subscriber: Jeff_G.
gerritbot subscribed.Nov 29 2017, 12:22 AM

Change 393964 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Fix undefined $db

https://gerrit.wikimedia.org/r/393964

gerritbot added a project: Patch-For-Review.Nov 29 2017, 12:22 AM

Change 393965 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@wmf/1.31.0-wmf.10] Fix undefined $db

https://gerrit.wikimedia.org/r/393965

gerritbot added a comment.Nov 29 2017, 12:31 AM

Change 393965 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.10] Fix undefined $db

https://gerrit.wikimedia.org/r/393965

Stashbot subscribed.Nov 29 2017, 12:33 AM

Mentioned in SAL (#wikimedia-operations) [2017-11-29T00:33:16Z] <reedy@tin> Synchronized php-1.31.0-wmf.10/includes/logging/LogPager.php: Fix fatal on Special:Log T181565 (duration: 00m 48s)

gerritbot added a comment.Nov 29 2017, 12:51 AM

Change 393964 merged by jenkins-bot:
[mediawiki/core@master] Fix undefined $db

https://gerrit.wikimedia.org/r/393964

Reedy closed this task as Resolved.Nov 29 2017, 12:57 AM
Reedy claimed this task.
Reedy removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 29 2017, 1:01 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits