Page MenuHomePhabricator

Advanced Search: Namespace Filters not working in dewiki
Closed, ResolvedPublic

Description

Advanced Search on deWikipedia seams to always search in Article-Namespace no matter wich namespace has been selected.
This issue occures only on some accounts; it occures when the URL-parameter "profile=default" is set by the search.

Example-URL

adv-search.png (596×641 px, 94 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Looks like I can reproduce this one locally.

The issue is profile default is used, so the namespace options are not loaded, when profile advanced should be used, which would load the namespaces.

Change 394276 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@master] Force search profile advanced

https://gerrit.wikimedia.org/r/394276

Change 394276 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Force search profile advanced

https://gerrit.wikimedia.org/r/394276

Change 394297 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@wmf/1.31.0-wmf.10] Force search profile advanced

https://gerrit.wikimedia.org/r/394297

Change 394299 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@wmf/1.31.0-wmf.8] Force search profile advanced

https://gerrit.wikimedia.org/r/394299

Change 394297 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@wmf/1.31.0-wmf.10] Force search profile advanced

https://gerrit.wikimedia.org/r/394297

Change 394299 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@wmf/1.31.0-wmf.8] Force search profile advanced

https://gerrit.wikimedia.org/r/394299

Mentioned in SAL (#wikimedia-operations) [2017-11-30T13:22:37Z] <addshore@tin> Synchronized php-1.31.0-wmf.8/extensions/AdvancedSearch/modules/ext.advancedSearch.init.js: pre-swat: T181644 Force search profile advanced in AdvancedSearch [[gerrit:394299]] (duration: 00m 50s)

Mentioned in SAL (#wikimedia-operations) [2017-11-30T13:23:41Z] <addshore@tin> Synchronized php-1.31.0-wmf.10/extensions/AdvancedSearch/modules/ext.advancedSearch.init.js: pre-swat: T181644 Force search profile advanced in AdvancedSearch [[gerrit:394297]] (duration: 00m 48s)

Backports for this issue done and it looks like it is working everywhere for me now.

HOWEVER, if you click the link in the description of this task you'll initially see the same behaviour. Clicking search again will then have the correct behaviour from advancedsearch.

I had the problem before, but now it works with different namepaces. Thanks, @Addshore!