Page MenuHomePhabricator

Background color extraction is not working as expected for Because you read and Continue reading cards
Closed, DeclinedPublic

Assigned To
None
Authored By
RHo
Nov 29 2017, 5:02 PM
Referenced Files
F11070375: image.png
Nov 29 2017, 5:02 PM
F11070387: image.png
Nov 29 2017, 5:02 PM
F11070370: image.png
Nov 29 2017, 5:02 PM
F11070366: image.png
Nov 29 2017, 5:02 PM

Description

Expected behavior
  • The color should be extracted for the background of the 'Because you read' and 'Continue reading' cards based on the predominant color of the thumbnail image of the corresponding article.
  • For articles without an image, use "Full-color borders and rules" color (from T172984) as the background-color
  • Text color should use light or dark theme depending on the background color
Actual behavior
  • Background color extracted is often quite inaccurate
  • Background color for articles without image is incorrect
  • Text color is always White

Some examples below:

image.png (533×1 px, 136 KB)
image.png (539×1 px, 68 KB)
image.png (322×750 px, 44 KB)
image.png (503×1 px, 184 KB)

Event Timeline

Note to self: compare using the inverseColor for extract instead of White/Black based on extracted bgcolor brightness

RHo triaged this task as Low priority.
RHo removed a project: good first task.
RHo raised the priority of this task from Low to Needs Triage.May 21 2018, 1:26 PM
RHo removed RHo as the assignee of this task.Oct 30 2018, 6:52 PM