Page MenuHomePhabricator

Support long titles in confirmation step of the new translation dialog
Closed, ResolvedPublic

Description

The "New translation" dialog (T111094) includes the article title in the confirmation step (the last step before you actually start translating). Article titles can be too long for the available space, especially on mobile:

small-screen-selected-source-page.PNG (2×1 px, 463 KB)

In order to better accommodate titles into the available space, it is proposed to :

  • When the title is longer than a certain length (and only in such case), reduce the font size used for the title. Reducing from the current 18px to 16px font size would help titles to better fit.
  • Make sure the external padding around the article detail info is respected. In the example below you can notice that the article title expanded to a point where it almost touches the border of the dialog on top.
Current stateProposal
Screen Shot 2017-11-30 at 11.48.59.png (268×874 px, 62 KB)
Screen Shot 2017-11-30 at 11.52.36.png (290×872 px, 65 KB)

Alternatively we can consider cropping titles up to a given length (ideally showing two lines), since the user already saw the full title in the previous step and displaying it in full at this stage is not a must.

Event Timeline

Change 400452 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Support long titles in selected source page

https://gerrit.wikimedia.org/r/400452

Change 400452 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Support long titles in selected source page

https://gerrit.wikimedia.org/r/400452

Checked the fix in cx-testing:

Screen Shot 2018-01-01 at 8.48.16 PM.png (223×879 px, 68 KB)

compare with enwiki (wmf.12)

Screen Shot 2018-01-01 at 8.39.46 PM.png (223×877 px, 63 KB)

@Petar.petkovic - there is a strange font color in the above screenshot. I did not find another example with the same font color.

@Petar.petkovic - there is a strange font color in the above screenshot. I did not find another example with the same font color.

Could that be the browser's font color for visited links?

@Petar.petkovic - it seems that you're right: if the article is visited, the title will be displayed as a visited link.