Page MenuHomePhabricator

wmf-auto-reimage: -c option cannot be specified alone
Closed, ResolvedPublic

Description

Due to some limitations in Python ( see https://bugs.python.org/issue9338 ) the current setup with -c that accept an optional value doesn't allow to use it as the only or last parameter.

These invocations will fail with the unhelpful message too few arguments:

wmf-auto-reimage -c hostname
wmf-auto-reimage -a -c hostname

While these will work

wmf-auto-reimage -c -- hostname
wmf-auto-reimage hostname -c
wmf-auto-reimage -c -a hostname

This limited behaviour should be documented and if possible also catch the unhelpful error and print a better error message in case -c was specified.

Event Timeline

Change 395662 had a related patch set uploaded (by Volans; owner: Volans):
[operations/puppet@production] wmf-auto-reimage: add --conftool-value option

https://gerrit.wikimedia.org/r/395662

Volans triaged this task as Medium priority.Dec 5 2017, 11:01 PM

Change 395662 merged by Volans:
[operations/puppet@production] wmf-auto-reimage: add --conftool-value option

https://gerrit.wikimedia.org/r/395662

Change 395718 had a related patch set uploaded (by Volans; owner: Volans):
[operations/puppet@production] wmf-auto-reimage: fix typo

https://gerrit.wikimedia.org/r/395718

Change 395718 merged by Volans:
[operations/puppet@production] wmf-auto-reimage: fix typo

https://gerrit.wikimedia.org/r/395718

Volans removed a project: Patch-For-Review.