- It should be a service
- It should be renamed to ThresholdLookup
- Some parts of it needs to be moved to a dedicated service called ThresholdParser
Anything more?
Anything more?
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Halfak | T183198 Scoring Platform FY18 Q3 | |||
Resolved | • Ladsgroup | T183199 ORES Extension refactoring | |||
Resolved | • Ladsgroup | T181892 Rewrite Stats.php |
Change 394760 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Rename Stats to ThresholdLookup and make it a service
Change 394760 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Rename Stats to ThresholdLookup and make it a service
Nah, I just renamed the class, way more work is needed (specially taking out the parsing part to a dedicated class). Back to "In progress" is better.
The Api.php is a PITA here, I need to find a way to ditch the whole Api class and use a better class
Change 400188 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] [WIP] Split ThresholdLookup into two class
Change 400188 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Split ThresholdLookup into two class
Change 400625 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Clean up ThresholdLookup
Change 400625 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Clean up ThresholdLookup
Change 402798 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Reorder attributes in ThresholdLookup
Change 402804 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Rename scoring variables to scoreFetcher
Change 402804 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Rename scoring variables to scoreFetcher
Change 402798 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Reorder attributes in ThresholdLookup