Page MenuHomePhabricator
Create Task
Maniphest T182050

Deprecate and replace mediawiki.ui components
Open, Needs TriagePublic
Actions

Description

NOTE: This can be removed when the following query returns zero results: https://codesearch.wmcloud.org/deployed/?q=mediawiki.ui%28%5C.button%7C%5C.anchor%7C%5C.input%7C%5C.radio%7C%5C.icon%7C%22%22%7C%27%29&files=&excludeFiles=%28docroot%2F.*%7Ctests%2F.*%7Ctest%2F.*%29&repos= and a solution has been found for on-wiki usage.

Coming from MinervaNeue default payload question:

We're still loading mediawiki.ui component code per default.
We should evaluate and remove styles from rendering-critical CSS

  • Deprecate mediawiki.ui

Buttons:
@Jdlrobson brought up the idea of reducing the CSS to load only normal state of button elements. When looking into mediawiki.ui/components/buttons.less it seems reasonably framed to progress. T193821
mediawiki.ui button-group
core

  • Special:GlobalRenameQueue

extensions:

  • Html2Wiki
  • ULS per JS

Exemplified:
mediawiki.ui checkbox is currently still in use in:

  • core
    • HTMLMultiSelectField.php
    • HTMLCheckMatrix.php
    • Xml.php
  • Extension:InputBox
  • Extension:MobileFrontend
  • Extension:Translate
  • Extension:UniversalLanguageSelector

mediawiki.ui radio:

Those should be replaced by similar OOUI PHP widgets and removed from loaded modules.

mediawiki.ui utilities

  • .mw-ui-flush-left
  • .mw-ui-flush-right
  • .mw-ui-center-block

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+208 -53Login page: Use Codex CSS components
mediawiki/coremaster+42 -80Drop UseMediaWikiUIEverywhere
mediawiki/skins/Examplemaster+0 -2Remove 'mediawiki.ui' dependencies
mediawiki/coremaster+13 -8EditPage: Use plain link rather than mw-ui-button for help link
mediawiki/coremaster+0 -84VFormHTMLForm: Remove dead code
mediawiki/coremaster+1 -27Remove mediawiki ui styles on OOUI forms
mediawiki/coremaster+0 -6Drop mw-ui-radio markup
mediawiki/coremaster+13 -0mediawiki.ui: Deprecate all sub-modules
mediawiki/extensions/Flowmaster+0 -50Remove unused CSS for MWUI components
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Dec 5 2017, 12:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2017, 12:19 AM
Volker_E added a project: UI-Standardization.Dec 5 2017, 12:20 AM
Volker_E added a comment.Dec 5 2017, 2:50 AM

mediawiki.ui inputs of type=search should be deprecated already. Everyone who wants to use such apart from OOUI needs to be aware of the vendor specific extensions of this HTML5 input type. AFAIK there's currently no usage of .mw-ui-input together with type=search any more.

Volker_E moved this task from Unsorted to mediawiki.ui on the UI-Standardization board.Dec 21 2017, 5:00 PM
gerritbot added a subscriber: gerritbot.Apr 26 2018, 10:25 AM

Change 429160 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Remove unused CSS for MWUI components

https://gerrit.wikimedia.org/r/429160

gerritbot added a project: Patch-For-Review.Apr 26 2018, 10:25 AM
gerritbot added a comment.May 1 2018, 12:00 AM

Change 429160 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove unused CSS for MWUI components

https://gerrit.wikimedia.org/r/429160

Volker_E updated the task description. (Show Details)May 1 2018, 12:03 AM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)May 1 2018, 12:22 AM
Krinkle awarded a token.May 1 2018, 12:32 AM
Krinkle added a project: MediaWiki-Interface.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).May 1 2018, 1:00 AM
Volker_E updated the task description. (Show Details)May 4 2018, 12:26 AM
Jdlrobson updated the task description. (Show Details)May 4 2018, 12:52 AM
Volker_E updated the task description. (Show Details)Dec 16 2018, 11:04 PM
Volker_E added a subscriber: Krinkle.
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:57 PM
Volker_E updated the task description. (Show Details)Oct 19 2019, 4:14 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 19 2019, 4:14 AM
Jdforrester-WMF closed subtask T235960: Remove 'mediawiki.ui.text' as Resolved.Oct 20 2019, 9:32 AM
Schnark added a subscriber: Schnark.Oct 21 2019, 7:28 AM
Jdlrobson changed the status of subtask T235937: Remove 'mediawiki.ui.icon' from Open to Stalled.Oct 23 2019, 5:28 PM
gerritbot added a comment.Jul 13 2020, 6:25 PM

Change 612397 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate all sub-modules

https://gerrit.wikimedia.org/r/612397

gerritbot added a project: Patch-For-Review.Jul 13 2020, 6:25 PM
Volker_E added a subtask: T235961: Remove 'mediawiki.ui.anchor' module.Jul 14 2020, 2:31 AM
Huji added a subtask: T258196: SpecialSearch warns regarding deprecated module "mediawiki.ui".Jul 17 2020, 2:02 PM
gerritbot added a comment.Feb 2 2021, 12:02 AM

Change 612397 abandoned by VolkerE:
[mediawiki/core@master] mediawiki.ui: Deprecate all sub-modules

Reason:

https://gerrit.wikimedia.org/r/612397

MPhamWMF closed subtask T258196: SpecialSearch warns regarding deprecated module "mediawiki.ui" as Declined.Aug 1 2022, 9:17 PM
Ladsgroup reopened subtask T258196: SpecialSearch warns regarding deprecated module "mediawiki.ui" as Open.Aug 1 2022, 9:22 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 1 2022, 9:30 PM
AnneT added a subscriber: AnneT.Nov 7 2022, 8:01 PM
Volker_E added a project: Design-Systems-Team.Nov 7 2022, 8:08 PM
egardner added a subscriber: egardner.Nov 7 2022, 10:18 PM
egardner moved this task from Requests to Following on the Design-Systems-Team board.Dec 20 2022, 11:13 PM
gerritbot added a comment.May 12 2023, 6:27 PM

Change 919360 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Remove mediawiki ui styles on OOUI forms

https://gerrit.wikimedia.org/r/919360

gerritbot added a project: Patch-For-Review.May 12 2023, 6:27 PM

Change 919361 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] [WIP] Login page: Use Codex CSS components

https://gerrit.wikimedia.org/r/919361

gerritbot added a comment.May 12 2023, 6:27 PM

Change 919392 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Drop mw-ui-radio markup

https://gerrit.wikimedia.org/r/919392

gerritbot added a comment.May 12 2023, 6:27 PM

Change 919393 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] VFormHTMLForm: Remove dead code

https://gerrit.wikimedia.org/r/919393

gerritbot added a comment.May 12 2023, 6:27 PM

Change 919394 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Drop UseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/919394

gerritbot added a comment.May 12 2023, 7:40 PM

Change 919398 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Use quiet button rather than mw-ui-button

https://gerrit.wikimedia.org/r/919398

gerritbot added a comment.May 12 2023, 8:20 PM

Change 919392 merged by jenkins-bot:

[mediawiki/core@master] Drop mw-ui-radio markup

https://gerrit.wikimedia.org/r/919392

gerritbot added a comment.May 15 2023, 1:08 PM

Change 919360 merged by jenkins-bot:

[mediawiki/core@master] Remove mediawiki ui styles on OOUI forms

https://gerrit.wikimedia.org/r/919360

gerritbot added a comment.May 15 2023, 1:12 PM

Change 919393 merged by jenkins-bot:

[mediawiki/core@master] VFormHTMLForm: Remove dead code

https://gerrit.wikimedia.org/r/919393

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 8:01 PM
gerritbot added a comment.May 16 2023, 8:02 PM

Change 919398 merged by jenkins-bot:

[mediawiki/core@master] EditPage: Use plain link rather than mw-ui-button for help link

https://gerrit.wikimedia.org/r/919398

Jdlrobson updated the task description. (Show Details)May 16 2023, 11:18 PM
gerritbot added a comment.May 25 2023, 5:07 AM

Change 922957 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Example@master] Remove 'mediawiki.ui' dependencies

https://gerrit.wikimedia.org/r/922957

gerritbot added a comment.Jun 9 2023, 6:07 PM

Change 922957 abandoned by Jdlrobson:

[mediawiki/skins/Example@master] Remove 'mediawiki.ui' dependencies

Reason:

Done in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Example/+/928887

https://gerrit.wikimedia.org/r/922957

PatchDemoBot added a comment.Jun 16 2023, 9:21 PM

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bc272f38d8/w

Jdlrobson added subtasks: T340255: Use Codex CSS components instead of mediawiki ui inside ULS dialog, T340256: Popups: Use Codex markup for buttons instead of mediawiki.ui markup, T340257: Replace mediawiki.ui.input and mediawiki.ui.radio with CSS components in codex-search-styles.Jun 23 2023, 8:50 PM
Jdlrobson added a subtask: T340260: NearbyPages should be updated to use Codex markup.Jun 23 2023, 8:58 PM
gerritbot added a comment.Jun 23 2023, 10:13 PM

Change 919394 abandoned by Jdlrobson:

[mediawiki/core@master] Drop UseMediaWikiUIEverywhere

Reason:

Lots of things to do beforehand so abandoning for now :-)

https://gerrit.wikimedia.org/r/919394

Jdlrobson closed subtask T235961: Remove 'mediawiki.ui.anchor' module as Resolved.Jun 27 2023, 12:31 AM
Jdlrobson added a parent task: T285398: Signup form hides fields and field names in mobile view.Jun 27 2023, 11:56 PM
Jdlrobson mentioned this in T285398: Signup form hides fields and field names in mobile view.
PatchDemoBot added a comment.Jul 1 2023, 12:23 AM

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/427782b8dc/w

PatchDemoBot added a comment.Jul 6 2023, 9:46 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/f5539e0094/w

PatchDemoBot added a comment.Jul 6 2023, 11:46 PM

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a1e0f00ea6/w

gerritbot added a comment.Jul 7 2023, 2:52 PM

Change 919361 merged by jenkins-bot:

[mediawiki/core@master] Login page: Use Codex CSS components

https://gerrit.wikimedia.org/r/919361

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.17; 2023-07-11); removed MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).Jul 7 2023, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 7 2023, 3:10 PM
Krinkle removed a subscriber: Krinkle.Jul 7 2023, 3:26 PM
stjn added a subscriber: stjn.EditedJul 10 2023, 10:00 PM

@Jdlrobson seems like a follow-up patch is needed to address this (form descriptions stick to the next elements in the form):

Looking at https://patchdemo.wmflabs.org/wikis/bc272f38d8/w/index.php?title=Special:CreateAccount&returnto=Main+Page

image.png (665×393 px, 48 KB)

Jdlrobson added a comment.Jul 10 2023, 10:11 PM

@stjn are you only seeing that on the patchdemo? I'm not seeing on https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:CreateAccount&campaign=loginCTA (which is the most up to date version of the code)
Looks like https://patchdemo.wmflabs.org/wikis/bc272f38d8/wiki/Main_Page is running patchset 6 of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/919361/ and we merged patchset 24 so the patchdemo is very outdated code.

stjn added a comment.Jul 10 2023, 10:13 PM

Ah. Assumed that since patchdemo was created not long ago, that’s what it looks like still. My apologies.

Lucas_Werkmeister_WMDE mentioned this in T341566: With $wgUseMediaWikiUIEverywhere = true, Xml::input() with class attribute causes warning or TypeError: htmlspecialchars() expects parameter 1 to be string, array given.Jul 11 2023, 10:45 AM
Edtadros closed subtask T340256: Popups: Use Codex markup for buttons instead of mediawiki.ui markup as Resolved.Jul 17 2023, 4:26 PM
matmarex removed a parent task: T285398: Signup form hides fields and field names in mobile view.Aug 18 2023, 6:38 PM
Jdlrobson updated the task description. (Show Details)Tue, Sep 19, 6:30 PM
Jdlrobson updated the task description. (Show Details)Tue, Sep 19, 6:32 PM
Jdlrobson updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL