Page MenuHomePhabricator
Create Task
Maniphest T182050

Remove all mediawiki.ui components and libraries in favor of Codex
Open, HighPublic
Actions

Assigned To
Jdlrobson
Authored By
Volker_E
Dec 5 2017, 12:19 AM
Tags
Referenced Files
F41607211: image.png
Dec 16 2023, 9:05 PM
File Not Attached
F37135239: image.png
Jul 10 2023, 10:00 PM
Subscribers
Aklapper
AnneT
Daimona
egardner
gerritbot
Iniquity
Jdlrobson
View All 15 Subscribers

Description

NOTE: This can be resolved when the following query returns zero results: https://codesearch.wmcloud.org/deployed/?q=mediawiki.ui%28%5C.button%7C%5C.anchor%7C%5C.checkbox%7C%5C.input%7C%5C.radio%7C%5C.icon%7C%22%22%7C%27%29&files=&excludeFiles=%28docroot%2F.*%7Ctests%2F.*%7Ctest%2F.*%29&repos= and a solution has been found for on-wiki usage.

Coming from MinervaNeue default payload question:

We're still loading mediawiki.ui component code per default.
We should evaluate and remove styles from rendering-critical CSS

  • Deprecate mediawiki.ui

mediawiki.ui ResourceLoader modules

done

radios only

inputs only

buttons only

inputs and checkboxes

buttons and radios and checkboxes

  • Extension:UniversalLanguageSelector (T340255)

buttons and icons

  • Extension:ContentTranslation (T340259)

buttons and inputs

Core

  • mediawiki.ui utilities; provides the CSS layout classes: .mw-ui-flush-left, .mw-ui-flush-right & .mw-ui-center-block
    • Fix remaining usages in T212095
    • Ensure that classes are not used in scripts (via GlobalSearch, example) & remove mixin code from MediaWiki core.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Flow should maintain a local version of MediaWiki UImediawiki/extensions/Flowmaster+454 -8
Remove unused CSS selectors and classesmediawiki/extensions/MobileFrontendmaster+2 -3
Adopt codex provided colors in more placemediawiki/extensions/Translatemaster+69 -57
Removes deprecated mediawiki.ui.button in favor of Codexmediawiki/extensions/GuidedTourmaster+29 -22
mediawiki.ui: Remove 'utilities.less'mediawiki/coremaster+1 -48
Remove uses of $wgUseMediaWikiUIEverywheremediawiki/coremaster+20 -222
Remove $wgUseMediaWikiUIEverywheremediawiki/coremaster+1 -32
Switch from mediawiki ui to Codex markupmediawiki/extensions/ExternalGuidancemaster+13 -6
Skin: Restore autoloading of mediawiki.ui.button stylesmediawiki/coremaster+4 -9
OAuthManageMyGrants: Remove mediawiki ui button stylesheetmediawiki/extensions/OAuthmaster+0 -2
Prepare for removal of $wgUseMediaWikiUIEverywhere in coremediawiki/extensions/MobileFrontendmaster+0 -43
Restrict autoloading of mediawiki ui button stylesmediawiki/coremaster+4 -1
Switch user page from mw-ui to Codexmediawiki/extensions/MobileFrontendmaster+2 -1
Remove unused CSS selectorsmediawiki/extensions/WikimediaMessagesmaster+0 -2
Login page: Use Codex CSS componentsmediawiki/coremaster+208 -53
Drop UseMediaWikiUIEverywheremediawiki/coremaster+42 -80
EditPage: Use plain link rather than mw-ui-button for help linkmediawiki/coremaster+13 -8
VFormHTMLForm: Remove dead codemediawiki/coremaster+0 -84
Remove mediawiki ui styles on OOUI formsmediawiki/coremaster+1 -27
Drop mw-ui-radio markupmediawiki/coremaster+0 -6
mediawiki.ui: Deprecate all sub-modulesmediawiki/coremaster+13 -0
Remove unused CSS for MWUI componentsmediawiki/extensions/Flowmaster+0 -50
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenJdlrobsonT182050 Remove all mediawiki.ui components and libraries in favor of Codex
 ResolvedmatmarexT212095 CentralAuth and Flow should not use mediawiki.ui utilities classes
 ResolvedBUG REPORTmatmarexT347514 Special:GlobalRenameQueue should not use mediawiki ui, should use tabs
 OpenNoneT235937 Remove 'mediawiki.ui.icon' module
 ResolvedBUG REPORTNoneT340256 Popups: Use Codex markup for buttons instead of mediawiki.ui markup
 ResolvedBUG REPORTJdlrobsonT340258 MMV should use Codex instead of mediawiki ui
 ResolvedCatropeT340570 Codex settings icon not working
 ResolvedBUG REPORTngkountasT340259 ContentTranslation shouldn't use mediawiki.ui modules
 ResolvedJdlrobsonT340262 Use Codex CSS Button components inside MobileFrontend
 ResolvedVolker_ET235960 Remove 'mediawiki.ui.text' module
 ResolvedJdlrobsonT235961 Remove 'mediawiki.ui.anchor' module
 ResolvedVolker_ET258196 SpecialSearch warns regarding deprecated module "mediawiki.ui"
 ResolvedBUG REPORTJdlrobsonT340255 [1.42] Use Codex CSS components instead of mediawiki ui inside ULS dialog
 ResolvedBUG REPORTNoneT340257 Replace mediawiki.ui.input and mediawiki.ui.radio with CSS components in codex-search-styles
 ResolvedBUG REPORTJdlrobsonT340260 NearbyPages should be updated to use Codex markup
 DuplicateNoneT340263 Deprecate mediawiki.ui.button. Use Codex markup instead.
 ResolvedJdlrobsonT346816 MobileFrontend editor is using deprecated mediawiki.ui.input
 ResolvedKSarabia-WMFT348069 Popups should not use mediawiki.ui.checkbox, use Codex instead
 OpenBUG REPORTNoneT353062 Core diff on mobile buggy codex thank button
 ResolvedNoneT350181 Enable desktop diff page on mobile site
 ResolvedBUG REPORTSBissonT353404 Wikistory showing on mobile diff page
 ResolvedJdlrobsonT353407 Diff footer is overlaying the text when visual diff is clicked
 ResolvedBUG REPORTJdlrobsonT353478 Diff tables collapse incorrectly on tablet breakpoint
 ResolvedJdlrobsonT357079 Wrong digit on bnwiki mobile diff
 ResolvedBUG REPORTJdlrobsonT345749 Mediaviewer button feels tight (differs from Codex demo)
 ResolvedNoneT353368 ConfirmEdit should not use the deprecated mediawiki.ui.input module in FancyCaptcha
 ResolvedJdlrobsonT353371 InputBox should not use deprecated mediawiki ui markup
 DuplicateNoneT354398 Translate extension shouldn't use mediawiki.ui modules, should use Codex.
 OpenNoneT355242 Determine a path forward for mediawiki.ui button styles in wikitext
 OpenNoneT343454 Use Codex CSS components or OOUI form instead of mediawiki.ui in Translate
 ResolvedWangombeT348516 Use Codex in Special:PagePreparation
 OpenNoneT354391 Stop using mediawiki.ui in Flow
 ResolvedmatmarexT408126 Deprecate the 'vform' HTMLForm display format
 ResolvedVolker_ET419930 Remove the `vform` HTMLForm display format
 OpenNoneT420125 Remove 'mediawiki.ui.input' module
 ResolvedVolker_ET420674 Remove 'mediawiki.ui.radio' module
 OpenNoneT420675 Remove 'mediawiki.ui.checkbox' module
 OpenNoneT420678 Remove 'mediawiki.ui' module
 OpenNoneT420685 Remove 'mediawiki.ui.button' module and gracefully handle remaining template calls
 Openabi_T421441 Remove mediawiki.ui module dependency

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson updated the task description. (Show Details)Jan 2 2024, 6:11 PM
Jdlrobson added a comment.Jan 2 2024, 6:33 PM

@Tacsipacsi thanks for flagging the bug - this is why code review is important! I appreciate you looking at it. I re-ran the script before the holidays.
I also got 518 when I tried the revised script which I have compiled into: https://docs.google.com/spreadsheets/d/19xK_rBTx2dhFQ67TOsXAJGG3O6FwPL09N6D9SMbMGI4/edit#gid=0
I got 1218 on main namespace but 1146 of those were subpages. Many of these are translations as I pointed out before. Looking closely https://meta.wikimedia.org/wiki/Wikimedia_Affiliates_Data_Portal and translations doesn't even use the library (it's improved without it). After the holidays and 5 edits by myself, it seems some of those fixes have propagated to translations as I expected - and that number has reduced to 968.

I'll be having some conversations with the design systems team and web team over the next few weeks about how we want to proceed with this deprecation.
It seems like it might also be useful for us to re-ignite the discussion around communication and impact to improve our shared understanding around communication between consumers and providers.

Jdlrobson updated the task description. (Show Details)Jan 4 2024, 4:25 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Jan 4 2024, 4:29 PM
gerritbot added a comment.Jan 4 2024, 11:59 PM

Change 987868 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Flow@master] Flow should maintain a local version of MediaWiki UI

https://gerrit.wikimedia.org/r/987868

Jdlrobson updated the task description. (Show Details)Jan 5 2024, 12:05 AM
Jdlrobson updated the task description. (Show Details)Jan 5 2024, 1:04 AM
Jdlrobson closed this task as Resolved.Jan 5 2024, 1:07 AM
Jdlrobson claimed this task.

Seems we missed a few @Volker_E

Jdlrobson reopened this task as Open.Jan 5 2024, 1:16 AM

Sorry wrong ticket :)

Jdlrobson merged a task: T340263: Deprecate mediawiki.ui.button. Use Codex markup instead..Jan 5 2024, 9:41 PM
Jdlrobson added subscribers: MJL, Daimona, taavi, Krinkle.
Volker_E removed a project: UI-Standardization.Jan 9 2024, 1:22 PM
Volker_E updated the task description. (Show Details)Jan 9 2024, 1:24 PM
Jdlrobson changed the status of subtask T353062: Core diff on mobile buggy codex thank button from Open to Stalled.Jan 12 2024, 5:09 PM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Jan 15 2024, 11:42 AM
Volker_E closed subtask T258196: SpecialSearch warns regarding deprecated module "mediawiki.ui" as Resolved.Jan 16 2024, 6:35 PM
Volker_E updated the task description. (Show Details)
CCiufo-WMF mentioned this in T355242: Determine a path forward for mediawiki.ui button styles in wikitext.Jan 17 2024, 4:03 PM
CCiufo-WMF added a subtask: T355242: Determine a path forward for mediawiki.ui button styles in wikitext.
KStoller-WMF moved this task from Inbox to Triaged on the Growth-Team board.Jan 23 2024, 9:51 AM
Iniquity moved this task from Backlog to Code health on the MediaWiki-extensions-InputBox board.Jan 25 2024, 8:55 PM
gerritbot added a comment.Feb 3 2024, 1:23 AM

Change 995375 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove uses of $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/995375

gerritbot added a comment.Feb 3 2024, 1:23 AM

Change 995376 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Remove $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/995376

gerritbot added a comment.Feb 5 2024, 1:59 PM

Change 995375 merged by jenkins-bot:

[mediawiki/core@master] Remove uses of $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/995375

gerritbot added a comment.Feb 5 2024, 2:29 PM

Change 995376 merged by jenkins-bot:

[mediawiki/core@master] Remove $wgUseMediaWikiUIEverywhere

https://gerrit.wikimedia.org/r/995376

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.17; 2024-02-06); removed MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Feb 5 2024, 3:01 PM
gerritbot added a comment.Feb 6 2024, 12:45 AM

Change 987868 abandoned by Jdlrobson:

[mediawiki/extensions/Flow@master] Flow should maintain a local version of MediaWiki UI

Reason:

Abandoning this as Design Systems Team will now be overseeing this now.

FWIW I think continuing to tie Flow to Codex design tokens is not worth the effort. We should be looking to undeploy this extension and applying pressure by degrading it as much as possible - even if that means it goes out of sync with other parts of the interface. Taking snapshots of the current CSS preserves it as it was. If we continue to support design tokens here we are effectively maintaining it and keeping it up to date with the rest of the codebase IMO and that doesn't seem like a great use of our time.

https://gerrit.wikimedia.org/r/987868

matmarex removed a subtask: T353002: RecentChanges, RecentChangesLinked and Watchlist should use Codex for their form elements.Feb 7 2024, 9:49 PM
matmarex mentioned this in T353002: RecentChanges, RecentChangesLinked and Watchlist should use Codex for their form elements.
Volker_E awarded a token.Feb 9 2024, 1:30 PM
Volker_E updated the task description. (Show Details)
Tacsipacsi updated the task description. (Show Details)Feb 10 2024, 3:24 PM
Jdlrobson changed the status of subtask T353062: Core diff on mobile buggy codex thank button from Stalled to Open.Feb 23 2024, 2:10 AM
gerritbot added a comment.Feb 29 2024, 2:19 PM

Change 982911 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Removes deprecated mediawiki.ui.button in favor of Codex

https://gerrit.wikimedia.org/r/982911

Volker_E updated the task description. (Show Details)Feb 29 2024, 2:20 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.21; 2024-03-05); removed MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Feb 29 2024, 5:00 PM
Jdlrobson removed a project: MediaWiki-extensions-GuidedTour.Feb 29 2024, 5:01 PM
CCiufo-WMF mentioned this in T360010: Future of OOUI and MediaWiki UI.Mar 13 2024, 3:28 PM
Izno added a subtask: T343454: Use Codex CSS components or OOUI form instead of mediawiki.ui in Translate.Mar 13 2024, 4:47 PM
Izno added a subtask: T354391: Stop using mediawiki.ui in Flow.
Volker_E updated the task description. (Show Details)Mar 15 2024, 8:49 AM
gerritbot added a comment.Mar 15 2024, 8:58 AM

Change 1011267 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.ui: Remove 'utilities.less'

https://gerrit.wikimedia.org/r/1011267

Volker_E added a project: CSS.Mar 15 2024, 10:46 AM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Mar 15 2024, 11:19 PM

Change 1011267 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.ui: Remove 'utilities.less'

https://gerrit.wikimedia.org/r/1011267

Jdlrobson updated the task description. (Show Details)Mar 15 2024, 11:22 PM
Jdlrobson updated the task description. (Show Details)
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.23; 2024-03-19); removed MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 16 2024, 1:00 AM
Volker_E updated the task description. (Show Details)Mar 16 2024, 6:23 PM
Volker_E updated the task description. (Show Details)Mar 19 2024, 1:51 PM
PatchDemoBot added a comment.Apr 23 2024, 1:18 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/f5539e0094/w/

PatchDemoBot added a comment.Apr 23 2024, 1:18 PM

Test wiki on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/a1e0f00ea6/w/

matmarex closed subtask T353368: ConfirmEdit should not use the deprecated mediawiki.ui.input module in FancyCaptcha as Resolved.Apr 29 2024, 5:22 PM
CCiufo-WMF updated the task description. (Show Details)Apr 29 2024, 5:50 PM
Pppery mentioned this in T364062: GuidedTour external link buttons don't work.May 3 2024, 4:05 AM
Pppery removed a project: Patch-For-Review.May 24 2024, 5:21 AM
CCiufo-WMF updated the task description. (Show Details)May 24 2024, 2:11 PM
Volker_E closed subtask T353371: InputBox should not use deprecated mediawiki ui markup as Resolved.Jun 26 2024, 1:59 PM
Volker_E updated the task description. (Show Details)
abi_ mentioned this in T375696: Translate should use Codex markup, not unsupported message markup.Sep 30 2024, 3:09 PM
gerritbot added a comment.Oct 25 2024, 1:10 PM

Change #1082216 had a related patch set uploaded (by Abijeet Patro; author: Ebrahim):

[mediawiki/extensions/Translate@master] Adopt codex provided colors in more place

https://gerrit.wikimedia.org/r/1082216

gerritbot added a project: Patch-For-Review.Oct 25 2024, 1:10 PM
gerritbot added a comment.Oct 26 2024, 6:34 AM

Change #1082216 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/extensions/Translate@master] Adopt codex provided colors in more place

https://gerrit.wikimedia.org/r/1082216

gerritbot added a comment.Oct 26 2024, 7:01 AM

Change #1082216 abandoned by Ebrahim:

[mediawiki/extensions/Translate@master] Adopt codex provided colors in more place

Reason:

There were some CSS files I've overlooked, let me retract this hopefully temporarily

https://gerrit.wikimedia.org/r/1082216

Jdlrobson-WMF triaged this task as High priority.Sep 10 2025, 9:32 PM
Jdlrobson-WMF added a project: Readers Essential Work (Codex).
matmarex added a subtask: T408126: Deprecate the 'vform' HTMLForm display format.Oct 23 2025, 2:39 PM
matmarex updated the task description. (Show Details)
matmarex closed subtask T408126: Deprecate the 'vform' HTMLForm display format as Resolved.Oct 24 2025, 1:11 PM
CCiufo-WMF updated the task description. (Show Details)Oct 24 2025, 1:33 PM
matmarex added a subtask: T419930: Remove the `vform` HTMLForm display format.Mar 13 2026, 2:48 PM
matmarex closed subtask T419930: Remove the `vform` HTMLForm display format as Resolved.
gerritbot added a comment.Mar 13 2026, 9:37 PM

Change #1251556 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MobileFrontend@master] Remove unused CSS selectors and classes

https://gerrit.wikimedia.org/r/1251556

gerritbot added a comment.Mar 13 2026, 10:53 PM

Change #1251556 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove unused CSS selectors and classes

https://gerrit.wikimedia.org/r/1251556

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 13 2026, 11:01 PM
Volker_E created subtask T420125: Remove 'mediawiki.ui.input' module.Sat, Mar 14, 8:58 PM
stjn unsubscribed.Sat, Mar 14, 9:14 PM
• BucheonFC closed subtask T420125: Remove 'mediawiki.ui.input' module as Invalid.Sun, Mar 15, 2:50 AM
Volker_E reopened subtask T420125: Remove 'mediawiki.ui.input' module as Open.Sun, Mar 15, 3:11 AM
• Wonmidong closed subtask T420125: Remove 'mediawiki.ui.input' module as Declined.Sun, Mar 15, 3:12 AM
AlexisJazz reopened subtask T420125: Remove 'mediawiki.ui.input' module as Open.Sun, Mar 15, 3:29 AM
Volker_E created subtask T420674: Remove 'mediawiki.ui.radio' module.Fri, Mar 20, 12:20 AM
Volker_E created subtask T420675: Remove 'mediawiki.ui.checkbox' module.Fri, Mar 20, 12:26 AM
Volker_E created subtask T420678: Remove 'mediawiki.ui' module.Fri, Mar 20, 1:48 AM
Volker_E created subtask T420685: Remove 'mediawiki.ui.button' module and gracefully handle remaining template calls.Fri, Mar 20, 2:25 AM
gerritbot added a comment.Fri, Mar 20, 2:44 AM

Change #922957 restored by VolkerE:

[mediawiki/skins/Example@master] Remove 'mediawiki.ui' dependencies

https://gerrit.wikimedia.org/r/922957

Volker_E closed subtask T420674: Remove 'mediawiki.ui.radio' module as Resolved.Tue, Mar 24, 6:15 AM
gerritbot added a comment.Tue, Mar 24, 3:51 PM

Change #987868 restored by VolkerE:

[mediawiki/extensions/Flow@master] Flow should maintain a local version of MediaWiki UI

https://gerrit.wikimedia.org/r/987868

Volker_E changed the status of subtask T235937: Remove 'mediawiki.ui.icon' module from Stalled to Open.Mon, Mar 30, 7:30 AM
gerritbot added a comment.Tue, Mar 31, 11:25 PM

Change #987868 abandoned by Jdlrobson:

[mediawiki/extensions/Flow@master] Flow should maintain a local version of MediaWiki UI

Reason:

Volker I don't have bandwidth for this any more - if you want to continue down this road would you mind re-posting it under your account?

https://gerrit.wikimedia.org/r/987868

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits