Page MenuHomePhabricator

Change class names to MediaWiki name conventions
Closed, DeclinedPublic

Event Timeline

Change 395197 had a related patch set uploaded (by Iniquity; owner: Iniquity):
[mediawiki/extensions/Babel@master] Change class names to MediaWiki name conventions. Migration period.

https://gerrit.wikimedia.org/r/395197

@Iniquity That seems accordingly. Notice though, that the ext- prefix hasn't seem to become very popular. Left comments on the patch too.

I don't really see a point to doing this. These class names are used in on-wiki styles, which would need to be updated for the new class name. I've also not seen anywhere use -ext, is that an actually adopted thing?

@Legoktm As I said above, doesn't seem to have become popular. We could still discuss if this might be helpful to identify extension specific class origin.
But Echo/Flow use mw-echo-/mw-flow- prefixes, VE uses ve-, MobileFrontend uses mf-
An edge case against it is also, when an extensions might turn into a core functionality.

Do we need to create a new task for discussion?

I'd rather avoid changing class names for one extensions unless there is a wide consensus for a convention. As of now it is total mess and isolated changes only create annoying churn without significant benefits.

Change 395197 abandoned by Iniquity:
Change class names to MediaWiki name conventions. Migration period.

https://gerrit.wikimedia.org/r/395197

Iniquity removed a project: Patch-For-Review.

Needs global discussion.