Page MenuHomePhabricator

[BUG] Regression - Default card footer actions on feed should not be blue
Closed, ResolvedPublic

Description

Steps to reproduce
  1. Open the app and scroll through the feed to view a Featured Article and Picture of the day card
  2. Tap on the 'Save' bookmark icon on a Featured Article card
Expected
  • Card footer actions on step 1 are in the Base30 color (in Light mode)
  • after the Featured article is saved, the bookmark icon changed from outline to filled, and the icon + action text color becomes Accent50 (in Light mode)
Picture of the day card footer
Featured article footer by default
Featured article footer after saving

Appears to be a regression of the app from version wikipedia-2.6.203-releasesprod-2017-08-28.apk where colors are appearing correctly.

Actual

Actions are showing as blue

Occurring on

Wikipedia v2.6.206-alpha-2017-12-04

Event Timeline

Change 395544 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Fix color of card footer icons.

https://gerrit.wikimedia.org/r/395544

RHo renamed this task from [BUG] Regression - Default card footer actions on feed are should not be blue to [BUG] Regression - Default card footer actions on feed should not be blue.Dec 5 2017, 2:55 PM

Change 395544 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix color of card footer icons.

https://gerrit.wikimedia.org/r/395544

Testing on Samsung-SM-JI20A Galaxy Express 3 (Android 6.0.1) and Wikipedia app 2.6.207-alpha-2017-12-04. In the attached video I removed all cards except for Featured Article and Picture of the day. The color blue is still used as an outline on all icons, "download" is always filled with blue even on pictures I did not download, for Featured Article the icons are only outlined blue and fill only after I add them to the reading list, but still, the above caps show that these icons should be gray instead. So this is not fixed.

Hi @Nicholas.tsg - I believe it is fixed in the latest version of the Alpha (from 5th Dec onward) v2.7.208-alpha-2017-12-05
Please retest on the the newer app version, thanks!

Dbrant claimed this task.