Page MenuHomePhabricator

Track entities to consider when checking whether cached constraint check result is valid
Closed, ResolvedPublic

Description

A CheckResult should hold a list of entity IDs which, when those entities are edited, should invalidate that check result. This set includes the current entity implicitly, but the “inverse”, “symmetric” and “target requires claim” checkers also add the target entity.

Patch-For-Review:

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseQualityConstraints : masterImplicitly track property of constraint
mediawiki/extensions/WikibaseQualityConstraints : masterImplicitly track current entity
mediawiki/extensions/WikibaseQualityConstraints : masterTrack target entity of inverse/symmetric/target checkers
mediawiki/extensions/WikibaseQualityConstraints : masterTrack entity IDs in CachingMetadata

Event Timeline

Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.
Lucas_Werkmeister_WMDE moved this task from Backlog to DOING on the Wikibase-Quality board.

Actually, I suppose logically this belongs inside the CachingMetadata, doesn’t it?

Change 396060 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Track entity IDs in CachingMetadata

https://gerrit.wikimedia.org/r/396060

Change 396062 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Track target entity of inverse/symmetric/target checkers

https://gerrit.wikimedia.org/r/396062

Change 396063 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Implicitly track current entity

https://gerrit.wikimedia.org/r/396063

Change 396320 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Implicitly track property of constraint

https://gerrit.wikimedia.org/r/396320

Change 396060 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Track entity IDs in CachingMetadata

https://gerrit.wikimedia.org/r/396060

Change 396062 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Track target entity of inverse/symmetric/target checkers

https://gerrit.wikimedia.org/r/396062

Jonas closed this task as Resolved.Dec 11 2017, 12:51 PM
Jonas updated the task description. (Show Details)
Jonas moved this task from Review to Done on the Wikidata-Sprint-2017-12-06 board.

Change 396063 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Implicitly track current entity

https://gerrit.wikimedia.org/r/396063

Change 396320 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Implicitly track property of constraint

https://gerrit.wikimedia.org/r/396320