Page MenuHomePhabricator

Only update constraints table when constraint statements were edited
Closed, ResolvedPublic

Description

Now that we have compact diffs in EntityChange (T113468), we can use those to only schedule an UpdateConstraintsTableJob when the constraint statements (P​2302 on Wikidata) were actually edited (which was previously not possible due to T163465).

Patch-For-Review:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2017, 3:27 PM

Change 392066 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Only schedule job if constraint statements were edited

https://gerrit.wikimedia.org/r/392066

Change 392066 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Only schedule job if constraint statements were edited

https://gerrit.wikimedia.org/r/392066

Change 395589 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rename WikibaseQualityConstraintsHooks function

https://gerrit.wikimedia.org/r/395589

Change 395590 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for WikibaseQualityConstraintsHooks::isConstraintStatementsChange

https://gerrit.wikimedia.org/r/395590

Change 395589 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rename WikibaseQualityConstraintsHooks function

https://gerrit.wikimedia.org/r/395589

Change 395590 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for WikibaseQualityConstraintsHooks::isConstraintStatementsChange

https://gerrit.wikimedia.org/r/395590

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 6 2017, 12:48 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2017-12-06 board.
Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.
Lucas_Werkmeister_WMDE moved this task from Backlog to DONE on the Wikibase-Quality board.